Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building retrievers with multiple docs (web pages or files) #13

Merged
merged 4 commits into from
Jul 1, 2024

Conversation

zhiheng-huang
Copy link
Contributor

@zhiheng-huang zhiheng-huang commented Jun 28, 2024

Description

Support scraping pages under a given domain. As a result. we now support building retrievers with multiple webpages or documents.

make formatting
All unit tests pass
make test
Verified the following toy experiments run okay.
poetry run python experiments/index_and_query_from_docs.py
poetry run python experiments/index_and_query_from_webpage.py

Related Issue

No

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@zhiheng-huang zhiheng-huang added the enhancement New feature or request label Jun 28, 2024
@zhiheng-huang zhiheng-huang requested a review from jotyy June 28, 2024 02:15
@zhiheng-huang zhiheng-huang self-assigned this Jun 28, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test output file should not be submitted.

@jotyy jotyy merged commit fdaca08 into main Jul 1, 2024
0 of 4 checks passed
@jotyy jotyy deleted the multi_docs branch July 1, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants