Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orr methodology #17

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Orr methodology #17

merged 2 commits into from
Jan 23, 2025

Conversation

Mo-Dell
Copy link
Collaborator

@Mo-Dell Mo-Dell commented Jan 22, 2025

As a contributor

By submitting this PR I confirm I have read and understood the Github Standards document and understand the role I play in ensuring standards, security, and assurance at DfT.

As a PR reviewer

By accepting this PR I understand my responsibilities as described in the the Github standards document.

Proposed changes

Added function to scrape ORR methodology information from pages.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Documentation Update (change to naming or other documentation)

Points I have checked in my code

Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • I have added unit tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have checked that my changes have not broken any other functionality
  • I have linked to any issues this PR fixes

Points for review

Add checkboxes here for any specific aspects of your PR you would like to be checked in peer review. If you don't specify anything here, the reviewer will check:

  • All of your unit tests pass
  • Your code is clear and easy to understand
  • You have documented any new features
  • They can run the code you have written
  • Your changes do not break any other functionality

Security considerations

Put an x in the boxes that apply. You should have considered all of these points before submitting a PR.

  • My code does not contain any secrets such as passwords, API keys, etc
  • I have not accidentally uploaded any data to Github
  • My code does not include any personal information such as names or email addresses

Who is reviewing this PR?

Tag your reviewer here to ensure they get a notification!

@Mo-Dell Mo-Dell self-assigned this Jan 22, 2025
Copy link
Contributor

@DIPAD-Fran-Bryden DIPAD-Fran-Bryden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good code and well documented 🥇

@Mo-Dell Mo-Dell merged commit 311c99a into main Jan 23, 2025
1 check passed
@Mo-Dell Mo-Dell deleted the orr_methodology branch January 23, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants