-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Live merge #7
Merged
Merged
Live merge #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er_function Bq tableizer function
…function Tidied df function
Mo-Dell
approved these changes
Aug 27, 2024
Have checked and it looks like the code works, besides the error in create_bq_table() function (which I think you mentioned was fixed in another PR). |
Loading status checks…
…ad_orr Feature/read orr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a contributor
By submitting this PR I confirm I have read and understood the Github Standards document and understand the role I play in ensuring standards, security, and assurance at DfT.
As a PR reviewer
By accepting this PR I understand my responsibilities as described in the the Github standards document.
Proposed changes
Merged in all three feature branches to hopefully reunite the unit testing family
Please note I have not done end to end testing on these, please check that everything works, tests run, and documentation is regenerated.
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyPoints I have checked in my code
Put an
x
in the boxes that apply. You can also fill these out after creating the PR.Points for review
Add checkboxes here for any specific aspects of your PR you would like to be checked in peer review. If you don't specify anything here, the reviewer will check:
Security considerations
Put an
x
in the boxes that apply. You should have considered all of these points before submitting a PR.Who is reviewing this PR?
@Mo-Dell