Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live merge #7

Merged
merged 55 commits into from
Sep 9, 2024
Merged

Live merge #7

merged 55 commits into from
Sep 9, 2024

Conversation

DIPAD-Fran-Bryden
Copy link
Contributor

As a contributor

By submitting this PR I confirm I have read and understood the Github Standards document and understand the role I play in ensuring standards, security, and assurance at DfT.

As a PR reviewer

By accepting this PR I understand my responsibilities as described in the the Github standards document.

Proposed changes

Merged in all three feature branches to hopefully reunite the unit testing family

Please note I have not done end to end testing on these, please check that everything works, tests run, and documentation is regenerated.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Documentation Update (change to naming or other documentation)

Points I have checked in my code

Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • I have added unit tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have checked that my changes have not broken any other functionality
  • I have linked to any issues this PR fixes

Points for review

Add checkboxes here for any specific aspects of your PR you would like to be checked in peer review. If you don't specify anything here, the reviewer will check:

  • All of your unit tests pass
  • Your code is clear and easy to understand
  • You have documented any new features
  • They can run the code you have written
  • Your changes do not break any other functionality

Security considerations

Put an x in the boxes that apply. You should have considered all of these points before submitting a PR.

  • My code does not contain any secrets such as passwords, API keys, etc
  • I have not accidentally uploaded any data to Github
  • My code does not include any personal information such as names or email addresses

Who is reviewing this PR?

@Mo-Dell

Mohan Dell and others added 30 commits August 7, 2024 11:45
@Mo-Dell
Copy link
Collaborator

Mo-Dell commented Sep 6, 2024

Have checked and it looks like the code works, besides the error in create_bq_table() function (which I think you mentioned was fixed in another PR).

…ad_orr

Feature/read orr
@DIPAD-Fran-Bryden DIPAD-Fran-Bryden merged commit c6e6c1e into main Sep 9, 2024
1 check failed
@DIPAD-Fran-Bryden DIPAD-Fran-Bryden restored the dev branch September 9, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants