Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

va-telephone: add health resource center number to constants #1455

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

Dr-Pongo
Copy link
Contributor

@Dr-Pongo Dr-Pongo commented Jan 14, 2025

Chromatic

https://adding-healthcare-telephone-number-constant--65a6e2ed2314f7b8f98609d8.chromatic.com


Configuring this pull request

  • Link to any related issues in the description so they can be cross-referenced.
    Health Resource Center telephone number va.gov-team#94773
  • Add the appropriate version patch label (major, minor, patch, or ignore-for-release).
    • See How to choose a version number for guidance.
    • Use ignore-for-release if files haven't been changed in a component library package. (ie. only Storybook files)
  • DST Only: Increment the /packages/core version number if this will be the last PR merged before a release.
  • Complete all sections below.
  • Delete this section once complete

Description

Adding a phone number to the telephone component contacts.js and the telephone web component contacts.ts since we use it a lot so we can have consistent implementation. Did my best filling this out but let me know if I need to provide any additional information!

Closes

QA Checklist

  • Component maintains 1:1 parity with design mocks
  • Text is consistent with what's been provided in the mocks
  • Component behaves as expected across breakpoints
  • Accessibility expert has signed off on code changes (if applicable. If not applicable provide reason why)
  • Designer has signed off on changes (if applicable. If not applicable provide reason why)
  • Tab order and focus state work as expected
  • Changes have been tested against screen readers (if applicable. If not applicable provide reason why)
  • New components are covered by e2e tests; updates to existing components are covered by existing test suite
  • Changes have been tested in vets-website using Verdaccio (if applicable. If not applicable provide reason why)

Screenshots

Acceptance criteria

  • QA checklist has been completed
  • Screenshots have been attached that cover desktop and mobile screens

Definition of done

  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue (or connected to it via ZenHub)

@Dr-Pongo Dr-Pongo added the minor For a minor Semantic Version change label Jan 14, 2025
@Dr-Pongo Dr-Pongo requested a review from a team as a code owner January 14, 2025 19:22
Copy link

@amponce amponce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 nice

Copy link
Contributor

@jamigibbs jamigibbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing!

Just a head's up for the next time, we have some branch naming requirements in order for the Chromatic preview link to work from the top of your PR description (I think yours is longer than 37 chars). It seems that our pre-commit hook didn't catch it.

But I verified the update loading locally here:

Screenshot 2025-01-15 at 9 04 12 AM

@jamigibbs jamigibbs added patch Patch change in semantic versioning and removed minor For a minor Semantic Version change labels Jan 15, 2025
@jamigibbs jamigibbs changed the title Adding phone number to constants va-telephone: add health resource center number to constants Jan 15, 2025
Copy link

@penny-lischer penny-lischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Dr-Pongo
Copy link
Contributor Author

Thank you for contributing!

Just a head's up for the next time, we have some branch naming requirements in order for the Chromatic preview link to work from the top of your PR description (I think yours is longer than 37 chars). It seems that our pre-commit hook didn't catch it.

@jamigibbs
Ahh thank you for the documentation, I'll do better next time! 🙏

@Dr-Pongo Dr-Pongo merged commit 0fc8fc8 into main Jan 15, 2025
8 checks passed
@Dr-Pongo Dr-Pongo deleted the adding-healthcare-telephone-number-constant branch January 15, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Patch change in semantic versioning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants