-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
va-telephone: add health resource center number to constants #1455
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing!
Just a head's up for the next time, we have some branch naming requirements in order for the Chromatic preview link to work from the top of your PR description (I think yours is longer than 37 chars). It seems that our pre-commit hook didn't catch it.
But I verified the update loading locally here:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@jamigibbs |
Chromatic
https://adding-healthcare-telephone-number-constant--65a6e2ed2314f7b8f98609d8.chromatic.com
Configuring this pull request
Health Resource Center telephone number va.gov-team#94773
major
,minor
,patch
, orignore-for-release
).ignore-for-release
if files haven't been changed in a component library package. (ie. only Storybook files)/packages/core
version number if this will be the last PR merged before a release.Description
Adding a phone number to the telephone component
contacts.js
and the telephone web componentcontacts.ts
since we use it a lot so we can have consistent implementation. Did my best filling this out but let me know if I need to provide any additional information!Closes
QA Checklist
Screenshots
Acceptance criteria
Definition of done