Update Rubocop TODOs

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2024-09-03 23:47:59 UTC using RuboCop version 1.59.0.
+# on 2024-10-03 23:29:44 UTC using RuboCop version 1.59.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -38,14 +38,14 @@ Capybara/CurrentPathExpectation:
     - 'spec/features/users/recommended_for_you_spec.rb'
     - 'spec/features/users/user_profile_spec.rb'
 
-# Offense count: 311
+# Offense count: 301
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: have_no, not_to
 Capybara/NegationMatcher:
   Enabled: false
 
-# Offense count: 128
+# Offense count: 129
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: DefaultSelector.
 Capybara/RSpec/HaveSelector:
@@ -57,7 +57,7 @@ Capybara/SpecificActions:
     - 'spec/features/crh_spec.rb'
     - 'spec/features/shared/breadcrumbs_spec.rb'
 
-# Offense count: 194
+# Offense count: 195
 # This cop supports safe autocorrection (--autocorrect).
 Capybara/SpecificFinders:
   Enabled: false
@@ -68,7 +68,7 @@ Capybara/SpecificMatcher:
     - 'spec/features/practice_editor/implementation/practice_resources_spec.rb'
     - 'spec/features/practice_editor/introduction/introduction_spec.rb'
 
-# Offense count: 89
+# Offense count: 90
 Capybara/VisibilityMatcher:
   Enabled: false
 
@@ -107,7 +107,7 @@ Lint/AmbiguousOperator:
     - 'app/admin/pages.rb'
     - 'app/admin/practices.rb'
 
-# Offense count: 3
+# Offense count: 4
 # This cop supports safe autocorrection (--autocorrect).
 Lint/AmbiguousOperatorPrecedence:
   Exclude:
@@ -193,26 +193,24 @@ Lint/RedundantDirGlobSort:
   Exclude:
     - 'spec/spec_helper.rb'
 
-# Offense count: 8
+# Offense count: 7
 # This cop supports safe autocorrection (--autocorrect).
 Lint/RedundantStringCoercion:
   Exclude:
     - 'app/admin/editor/pages.rb'
-    - 'app/admin/homepage.rb'
     - 'app/admin/pages.rb'
     - 'app/admin/site_metrics.rb'
     - 'app/helpers/application_helper.rb'
     - 'lib/tasks/va_facilities.rake'
 
-# Offense count: 10
+# Offense count: 7
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowedMethods.
 # AllowedMethods: present?, blank?, presence, presence_in, try, try!, in?
 Lint/SafeNavigationChain:
   Exclude:
     - 'app/admin/editor/pages.rb'
     - 'app/admin/pages.rb'
-    - 'app/controllers/home_controller.rb'
     - 'lib/tasks/importer.rake'
 
 # Offense count: 74
@@ -241,7 +239,7 @@ Lint/UnderscorePrefixedVariableName:
     - 'app/models/page_component.rb'
     - 'app/models/user.rb'
 
-# Offense count: 38
+# Offense count: 37
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
 Lint/UnusedBlockArgument:
@@ -254,6 +252,7 @@ Lint/UnusedBlockArgument:
     - 'config/initializers/commontator.rb'
     - 'lib/classes/params.rb'
     - 'lib/tasks/importer.rake'
+    - 'spec/factories/homepages.rb'
     - 'spec/features/pages/event_component_spec.rb'
     - 'spec/features/practice_editor/overview/video_spec.rb'
 
@@ -322,12 +321,12 @@ Metrics/BlockNesting:
 Metrics/ClassLength:
   Max: 405
 
-# Offense count: 56
+# Offense count: 57
 # Configuration parameters: AllowedMethods, AllowedPatterns.
 Metrics/CyclomaticComplexity:
   Max: 78
 
-# Offense count: 182
+# Offense count: 181
 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
 Metrics/MethodLength:
   Max: 224
@@ -431,17 +430,18 @@ Performance/MapCompact:
     - 'app/admin/users.rb'
     - 'app/models/diffusion_history_status.rb'
 
-# Offense count: 11
+# Offense count: 10
 # This cop supports safe autocorrection (--autocorrect).
 Performance/RedundantSplitRegexpArgument:
   Exclude:
     - 'lib/tasks/importer.rake'
 
-# Offense count: 19
+# Offense count: 21
 # This cop supports safe autocorrection (--autocorrect).
 Performance/RedundantStringChars:
   Exclude:
     - 'app/models/concerns/text_and_image_component.rb'
+    - 'app/models/homepage_feature.rb'
     - 'app/models/page_component_image.rb'
     - 'app/models/page_event_component.rb'
     - 'app/models/page_header2_component.rb'
@@ -550,7 +550,7 @@ RSpec/EmptyLineAfterHook:
     - 'spec/requests/page_resources_controller_spec.rb'
     - 'spec/tasks/importer_spec.rb'
 
-# Offense count: 366
+# Offense count: 370
 # Configuration parameters: CountAsOne.
 RSpec/ExampleLength:
   Max: 232
@@ -595,7 +595,7 @@ RSpec/HookArgument:
   Exclude:
     - 'spec/rails_helper.rb'
 
-# Offense count: 147
+# Offense count: 141
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: is_expected, should
@@ -614,7 +614,7 @@ RSpec/IndexedLet:
     - 'spec/models/va_facility_spec.rb'
     - 'spec/services/practice_mailer_service_spec.rb'
 
-# Offense count: 1684
+# Offense count: 1698
 # Configuration parameters: AssignmentOnly.
 RSpec/InstanceVariable:
   Enabled: false
@@ -633,7 +633,7 @@ RSpec/LetSetup:
 RSpec/MetadataStyle:
   Enabled: false
 
-# Offense count: 499
+# Offense count: 503
 RSpec/MultipleExpectations:
   Max: 96
 
@@ -677,7 +677,12 @@ RSpec/NoExpectationExample:
 RSpec/NotToNot:
   Enabled: false
 
-# Offense count: 162
+# Offense count: 3
+RSpec/PendingWithoutReason:
+  Exclude:
+    - 'spec/features/shared/header_spec.rb'
+
+# Offense count: 160
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: Inferences.
 RSpec/Rails/InferredSpecType:
@@ -868,7 +873,7 @@ Rails/EnvironmentComparison:
   Exclude:
     - 'config/initializers/opentelemetry.rb'
 
-# Offense count: 72
+# Offense count: 73
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: slashes, arguments
@@ -919,7 +924,7 @@ Rails/HttpStatus:
   Exclude:
     - 'app/controllers/errors_controller.rb'
 
-# Offense count: 25
+# Offense count: 26
 Rails/I18nLocaleTexts:
   Exclude:
     - 'app/admin/categories.rb'
@@ -928,6 +933,7 @@ Rails/I18nLocaleTexts:
     - 'app/admin/page_group.rb'
     - 'app/admin/practices.rb'
     - 'app/controllers/application_controller.rb'
+    - 'app/controllers/home_controller.rb'
     - 'app/controllers/nominate_practices_controller.rb'
     - 'app/controllers/practices_controller.rb'
     - 'app/controllers/session_timeout_controller.rb'
@@ -1013,12 +1019,11 @@ Rails/PluralizationGrammar:
     - 'spec/features/admin/admin_adoptions_spec.rb'
     - 'spec/features/admin/site_metrics_spec.rb'
 
-# Offense count: 10
+# Offense count: 8
 # This cop supports safe autocorrection (--autocorrect).
 Rails/Presence:
   Exclude:
     - 'app/admin/editor/page_group.rb'
-    - 'app/admin/homepage.rb'
     - 'app/admin/page_group.rb'
     - 'app/controllers/practices_controller.rb'
     - 'app/controllers/va_facilities_controller.rb'
@@ -1064,7 +1069,7 @@ Rails/RequestReferer:
   Exclude:
     - 'app/controllers/practices_controller.rb'
 
-# Offense count: 13
+# Offense count: 16
 # Configuration parameters: Include.
 # Include: db/**/*.rb
 Rails/ReversibleMigration:
@@ -1075,6 +1080,7 @@ Rails/ReversibleMigration:
     - 'db/migrate/20240718220057_drop_badge_practices_and_badges_tables.rb'
     - 'db/migrate/20240725224021_drop_topics.rb'
     - 'db/migrate/20240819013959_drop_retired_file_models.rb'
+    - 'db/migrate/20240920234630_drop_retired_importer_models.rb'
 
 # Offense count: 17
 # This cop supports unsafe autocorrection (--autocorrect-all).
@@ -1097,10 +1103,10 @@ Rails/RootPathnameMethods:
 # ForbiddenMethods: decrement!, decrement_counter, increment!, increment_counter, insert, insert!, insert_all, insert_all!, toggle!, touch, touch_all, update_all, update_attribute, update_column, update_columns, update_counters, upsert, upsert_all
 Rails/SkipsModelValidations:
   Exclude:
-    - 'app/admin/homepage.rb'
     - 'app/controllers/users_controller.rb'
     - 'app/models/commontator/comment.rb'
     - 'app/models/commontator/thread.rb'
+    - 'app/models/homepage.rb'
     - 'app/services/practice_mailer_service.rb'
     - 'db/migrate/20230927000910_add_service_name_to_active_storage_blobs.active_storage.rb'
     - 'db/migrate/20231127172710_add_public_to_pages.rb'
@@ -1118,7 +1124,7 @@ Rails/SquishedSQLHeredocs:
 Rails/ThreeStateBooleanColumn:
   Enabled: false
 
-# Offense count: 302
+# Offense count: 303
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: strict, flexible