New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Do not use assets URL for fonts #836

Closed

ph-One wants to merge 1 commit into main from km/fonts/generated-not-asset

Contributor

ph-One commented Dec 11, 2024

Do not use ${ASSETS_URL} for anything other than *.js and *.css
JS and CSS point to the assets bucket https://github.com/department-of-veterans-affairs/vsp-platform-revproxy/blob/main/template-rendering/revproxy-vagov/templates/nginx_website_server.conf.j2#L332
All other resources are pointed at the [next]content bucket https://github.com/department-of-veterans-affairs/vsp-platform-revproxy/blob/main/template-rendering/revproxy-vagov/templates/nginx_website_server.conf.j2#L402


          fix: Do not use assets URL for fonts

1874eff

- Do not use `${ASSETS_URL}` for anything other than `*.js` and `*.css`

Contributor Author

ph-One commented Dec 11, 2024

The root cause was missing files in the assets bucket. Nothing to change. Closing this PR.

ph-One closed this

timcosgrove requested changes

View reviewed changes

Contributor

timcosgrove left a comment

/generated still pulls from vets-website ultimately. This wouldn't solve anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet