Check banner object for field before trying to iterate over it. #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eselkin
approved these changes
Dec 12, 2024
|
Looks good to me +1 Went to https://pr840-xxegfpomzm0ryj6qekdo8eodojtrjvbo.tugboat.vfs.va.gov/boston-health-care/events/ and it's loading with the banner.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Banner data did not contain a field we were expecting and the banner code attempted to iterate over it.
This threw an error which caused the entire page to not be built, which is a problem for us.
Ticket
QA steps
Visit /boston-health-care/events on this Tugboat instance; it should show a page.