VAGOV-CMS- 9474: Remove old recurring events from View Other Times for this event dropdown

[chriskim2311]

Description

We are removing any recurring events that are in the past so the add to calendar links are relevant with current or future events only. Unit tests were updated as well to accompany this change. We also fixed a playwright test that was failing.

Ticket

#9474

Developer Task

Tasks

Preview Give feedback

1. PR submitted against the main branch of next-build.
2. Link to the issue that this PR addresses (if applicable).
3. Define all changes in your PR and note any changes that could potentially be breaking changes.
4. PR includes steps to test your changes and links to these changes in the Tugboat preview (if applicable).
5. Provided before and after screenshots of your changes (if applicable).
6. Alerted the #accelerated-publishing Slack channel to request a PR review.
7. You understand that once approved, you are responsible for merging your changes into main. (Note that changes to main will move automatically into production.)

Testing Steps

Tested this against recurring events locally. Check and see if any old dates are being shown for those type of events.
URL for testing: /outreach-and-events/events/64661/

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

Screenshots

Before:

After:

Is this PR blocked by another PR?

• Add the DO NOT MERGE label
• Add links to additional PRs here:

Reviewer

Reviewing a PR

This section lists items that need to be checked or updated when making changes to this repository.

Standard Checks

Tasks

Preview Give feedback

1. Code Quality: Readabilty, Naming Conventions, Consistency, Reusability
2. Test Coverage: 80% coverage
3. Functionality: Change functions as expected with no additional bugs
4. Performance: Code does not introduce performance issues
5. Documentation: Changes are documented in their respective README.md files
6. Security: Packages have been approved in the TRM

Merging an Approved Layout

When merging a layout, you must ensure that the content type has been turned on for next-build inside the CMS. This CMS flag must be turned on for editors to preview their work using the next build preview server.

Resource types (layouts) that have not been approved by design should NOT be pushed to production. Ensure that slug.tsx does not include your resource type if it is not approved.

The status of layouts should be kept up to date inside templates.md. This includes QA progress, development progress, etc. A link should be provided for where testing can occur.

Merging a Non-Approved Layout

Your new resource type should not be included inside slug.tsx. Items added here will go into production once merged into the main branch. It is imperative that we do not push anything live that has not been approved.

Ensure that this layout has been added to the templates.md file with the current status of the work.

[randimays]

I spun this up locally at http://localhost:3999/central-western-massachusetts-health-care/events/73034/ and I'm seeing the below. @chriskim2311 are there correct times/dates on your end?

[chriskim2311]

@randimays Thanks for looking into that there was a formatting issue but the dates were being filtered properly. Also I was looking at the dates for a bit and realized the times for that event are around 2 months in length. I found a better example to test the changes against here. /outreach-and-events/events/75572/

Before:

After:

[va-cms-bot]

Tugboat has finished building the preview for this pull request!

Links:

• https://pr849-hixazhe1mvxwayxmy68u1rdrbuyq7thv.tugboat.vfs.va.gov
• https://storybook-hixazhe1mvxwayxmy68u1rdrbuyq7thv.tugboat.vfs.va.gov

Link (redis):

• https://pr849-szq28xijk9d1d8hgtel99onzofbekqoa.tugboat.vfs.va.gov

Dashboard:

• https://tugboat.vfs.va.gov/6760c9b992d45af707df8a9a

[randimays]

I checked your example and all the other events that are available and I found this one is still showing past events: /central-western-massachusetts-health-care/events/73034/ even though the accordion should not be there.

[chriskim2311]

Hey @randimays! Sorry if my comment wasn't clear before but this specific event has start times in October and end times in December. We are currently filtering based on end time which is why these are still showing. So the most recent date for this event is actually still ongoing. I would say this is bad data and does not align with other use cases of the recurring event dates.

[randimays]

Thanks for the clarification! LGTM