Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/9615-BiometricLoginRefreshTokenFix #10040

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

bug/9615-BiometricLoginRefreshTokenFix #10040

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
211906e
set storage to AES
Sparowhawk Oct 25, 2024
aaf9fb3
unit test
Sparowhawk Oct 25, 2024
8fcdefa
updated unit tests
Sparowhawk Oct 29, 2024
9aec8ce
Merge branch 'develop' into bug/9615-BiometricLoginRefreshTokenFix
rbontrager Nov 13, 2024
70e1fd7
Merge branch 'develop' into bug/9615-BiometricLoginRefreshTokenFix
Sparowhawk Nov 14, 2024
462ebde
fixed upgrade from dev
Sparowhawk Nov 14, 2024
1dfdd33
updated
Sparowhawk Nov 14, 2024
a86468c
apparently not broken
Sparowhawk Nov 14, 2024
cfa8326
updated
Sparowhawk Nov 14, 2024
870a724
updated
Sparowhawk Nov 14, 2024
8d5d720
updated
Sparowhawk Nov 14, 2024
0133dd1
updated
Sparowhawk Nov 14, 2024
a4aae5e
updated
Sparowhawk Nov 14, 2024
e8228f8
updated
Sparowhawk Nov 14, 2024
75237c2
updated
Sparowhawk Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions VAMobile/src/store/slices/authSlice.sis.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,7 @@ context('authAction SIS', () => {
accessControl: Keychain.ACCESS_CONTROL.BIOMETRY_ANY,
accessible: Keychain.ACCESSIBLE.WHEN_UNLOCKED,
authenticationType: Keychain.AUTHENTICATION_TYPE.BIOMETRICS,
storage: Keychain.STORAGE_TYPE.AES,
})
expect(Keychain.setInternetCredentials).toHaveBeenCalledWith('vamobile', 'user', nonce, expectedOpts)
})
Expand Down
2 changes: 2 additions & 0 deletions VAMobile/src/store/slices/authSlice.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,7 @@ const saveRefreshToken = async (refreshToken: string): Promise<void> => {
accessControl: Keychain.ACCESS_CONTROL.BIOMETRY_ANY,
authenticationType: Keychain.AUTHENTICATION_TYPE.BIOMETRICS,
securityLevel: Keychain.SECURITY_LEVEL.SECURE_SOFTWARE,
storage: Keychain.STORAGE_TYPE.AES,
}
console.debug('saveRefreshToken:', options)
console.debug('saveRefreshToken: saving refresh token to keychain')
Expand All @@ -289,6 +290,7 @@ const saveRefreshToken = async (refreshToken: string): Promise<void> => {
accessible: Keychain.ACCESSIBLE.WHEN_UNLOCKED,
accessControl: Keychain.ACCESS_CONTROL.DEVICE_PASSCODE,
securityLevel: Keychain.SECURITY_LEVEL.SECURE_SOFTWARE,
storage: Keychain.STORAGE_TYPE.AES,
}
console.debug('saveRefreshToken:', options)
console.debug('saveRefreshToken: saving refresh token to keychain')
Expand Down
Loading