Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce height of checkmark icon #10403

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

kimmccaskill-oddball
Copy link
Contributor

@kimmccaskill-oddball kimmccaskill-oddball commented Jan 14, 2025

Description of Change

Link to issue
The chevron height for the theme dimensions were set at 45px. This caused extra space when the contents to the left of the chevron were less than that.
While there were multiple instances of the chevronListItemHeight with the chevron icon in the app, these before/after images were the ones I found that made a difference in the height. The reason others wouldn't change is because the content that precedes it is taller than the height of the chevon

Screenshots/Video

Before After
Screenshot 2025-01-14 at 10 40 37 AM Screenshot 2025-01-14 at 10 47 53 AM
Screenshot 2025-01-14 at 10 42 27 AM Screenshot 2025-01-14 at 10 47 14 AM
Screenshot 2025-01-14 at 10 59 10 AM Screenshot 2025-01-14 at 10 55 49 AM

Testing

  • Tested on iOS
  • Tested on Android

Reviewer Validations

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant