Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-20435: Updates description meta tag for va forms to use field_v… #20709

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

dsasser
Copy link
Contributor

@dsasser dsasser commented Feb 26, 2025

Description

Updates description meta tag for va forms to use field_va_form_name

Relates to #20435

Testing done

Manual but we need a full TB instance to check end-to-end that the meta tag is making its way to the FE. confirmed.

Screenshots

SPIKE-20435-va-form-metatag-using-form-name-tugboat

QA steps

Steps to view meta description in Chrome developer tools

  • Open developer tools
  • Click Elements tab
  • Using search feature in Developer tools, search for Description and look at <meta name="description" content="">

Example of meta description tag:
Screenshot 2025-02-26 at 9 20 00 AM

Forms:

Form Name Drupal Link Frontend Link Note
Nonsupervised Lender's Nomination and Recommendation of Credit Underwriter /find-forms/about-form-26-8736a /find-forms/about-form-26-8736a Spot check
Clinical Trial Inclusion/Enrollment Report /find-forms/about-form-10-0455a /find-forms/about-form-10-0455a Spot check
CHAMPVA Benefits Election Affirmation /find-forms/about-form-10-493b /find-forms/about-form-10-493b Spot check
CHAMPVA—Other Health Insurance (OHI) Certification /find-forms/about-form-10-7959c /find-forms/about-form-10-7959c Form with 'When to use' data
VA Advance Directive: Durable Power of Attorney for Health Care and Living Will /find-forms/about-form-10-0137 /find-forms/about-form-10-0137 Form with 'When to use' data

As content admin

  1. For each of the above Forms
    • Visit the Drupal link and confirm the Form Name matches the provided Form Name in the table
    • Visit the Frontend link and confirm the meta description tag content matches the provided Form Name
    • If the Form has 'When to use' note, confirm that the meta description no longer matches the 'When to use' value in Drupal.

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 26, 2025 17:24 Destroyed
Copy link

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 26, 2025 19:45 Destroyed
Copy link

Checking composer.lock changes...

Copy link
Contributor

@omahane omahane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first 3 in the QA steps works as described and as expected. Plus, they differed from Prod, which is what I'd expect.

VA Form 10-7959C, however, differed from the preceding, matched prod and has data whose origin I can't find.

Screenshot 2025-02-26 at 16 06 02

@dsasser
Copy link
Contributor Author

dsasser commented Feb 26, 2025

The first 3 in the QA steps works as described and as expected. Plus, they differed from Prod, which is what I'd expect.

VA Form 10-7959C, however, differed from the preceding, matched prod and has data whose origin I can't find.

Screenshot 2025-02-26 at 16 06 02

Found the root cause:
The description data is coming from a "hidden" (via entity form display) field, field_meta_tags. Will determine next steps with team.

I also found where we hid the meta tags field from editors: #3310

@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 27, 2025 08:38 Destroyed
…epartment-of-veterans-affairs/va.gov-cms into VACMS-20435-spike-va-forms-description
Copy link

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 27, 2025 17:40 Destroyed
Copy link

Checking composer.lock changes...

Copy link
Contributor

@omahane omahane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as designed. Good investigation.

@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 27, 2025 21:18 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 27, 2025 21:35 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 28, 2025 00:08 Destroyed
Copy link

Checking composer.lock changes...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants