Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-20499: Updatdes CLP default metatag to include description. #20715

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dsasser
Copy link
Contributor

@dsasser dsasser commented Feb 26, 2025

Description

Updates description meta tag for Campaign Landing Pages to use field_clp_why_this_matters.

Relates to #20499

Testing done

Manual.

Screenshots

Screenshot 2025-02-26 at 2 16 52 PM

QA steps

Steps to view meta description in Chrome developer tools

  • Open developer tools
  • Click Elements tab
  • Using search feature in Developer tools, search for Description and look at <meta name="description" content="">

Test Content:

Drupal Edit Link Frontend Link Prod Link
Prepare for VA’s secure sign-in changes /initiatives/prepare-for-vas-secure-sign-in-changes /initiatives/prepare-for-vas-secure-sign-in-changes
Protecting Veterans from fraud /initiatives/protecting-veterans-from-fraud /initiatives/protecting-veterans-from-fraud
Veteran Trust in VA /initiatives/veteran-trust-in-va /initiatives/veteran-trust-in-va

As content admin (in Drupal, anonymous in Frontend links):
For each of the above test content:

  • Visit the 'Drupal Edit Link'
  • Scroll to the 'Why this matters' section
  • Note the 'Introduction' text
  • Open the 'Frontend Link' in a new tab
  • Open Developer tools or view the content source
  • Validate the 'description' meta tag matches the 'Introduction' text
  • Visit the 'Prod Link'
  • Open Developer tools or view the content source
  • Validate the 'description' meta tag is absent or contains empty text
  • Repeat for each of the above test content

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

…ved from the field_clp_why_this_matters field.
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 26, 2025 21:00 Destroyed
Copy link

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 26, 2025 21:12 Destroyed
Copy link

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 27, 2025 08:49 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 27, 2025 16:23 Destroyed
Copy link
Contributor

@omahane omahane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as advertised.

I do think someone should revisit these fields, though, and remove the HTML entities that looked like they are pasted in from Word or something like that.

Screenshot 2025-02-27 at 17 21 30

@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 28, 2025 00:07 Destroyed
Copy link

Checking composer.lock changes...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants