VACMS-20371: Clean up extensions #20730
Conversation
|
Checking composer.lock changes... |
| @@ -74,14 +74,14 @@ public function processOne(string $key, mixed $item, array &$sandbox): string { | |||
| } | |||
| $number_only_extension = $this->replaceNonNumerals($original_extension); | |||
| if ($original_extension === $number_only_extension) { | |||
| return "No change to extension $original_extension in paragraph id $item"; | |||
| return "No change to extension '$original_extension' in paragraph id $item"; | |||
There was a problem hiding this comment.
Nice. Not sure how we both missed this. Alternatively, return "No change to extension {$original_extension} in paragraph id $item"
| return []; | ||
| } | ||
| $first_extension = []; | ||
| preg_match('/^\d+/', $dual_extension, $first_extension); | ||
| $second_extension = []; | ||
| preg_match('/\d+$/', $dual_extension, $second_extension); | ||
|
|
||
| return [$first_extension[0], $second_extension[0]]; | ||
| return [trim($first_extension[0]), trim($second_extension[0])]; |
There was a problem hiding this comment.
SHOULD:
At this point in the code there is no guarantee that index 0 is available for either string. You might want to return early if they are not set, or set them to defaults before accessing them in trim() here.
|
Checking composer.lock changes... |
github-actions
bot
added
the
Facilities
|
Checking composer.lock changes... |
|
Checking composer.lock changes... |
|
Tugboat has finished building the preview for this pull request! Links:
Dashboard: |
Cypress Accessibility Violations
|
Description
Relates to #20371
Testing done
Screenshots
QA steps
What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?
As user uid with user_role
Definition of Done
Select Team for PR review
CMS TeamPublic websitesFacilitiesUser supportAccelerated PublishingIs this PR blocked by another PR?
DO NOT MERGEDoes this PR need review from a Product Owner
Needs PO reviewCMS user-facing announcement
Is an announcement needed to let editors know of this change?