Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TERA conditional logic from the Health Care Application #34491

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

longmd
Copy link
Contributor

@longmd longmd commented Feb 4, 2025

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

Now that the TERA questions are permanent in the health care application, we can remove the feature toggle and any other unnecessary logic from the code. This PR removes the conditional logic and makes the questions permanent.

Related issue(s)

department-of-veterans-affairs/va.gov-team#101579

Acceptance criteria

  • No unnecessary logic exists in the codebase

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution

@longmd longmd marked this pull request as ready for review February 4, 2025 19:22
@longmd longmd requested review from a team as code owners February 4, 2025 19:22
Copy link
Contributor

@JoshingYou1 JoshingYou1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@coope93 coope93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I assume we want to remove the toggle from featureFlagNames.json and the vets-api features.yml file in a future PR as well?

@longmd
Copy link
Contributor Author

longmd commented Feb 6, 2025

Correct! These will be separate PRs to keep this work inside the CD pipeline.

@longmd longmd merged commit eea9272 into main Feb 7, 2025
84 of 85 checks passed
@longmd longmd deleted the longmd-101579-hca-remove-tera-conditional branch February 7, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants