-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SIMPLE-FORMS] feat: update form id for form upload flow #34503
[SIMPLE-FORMS] feat: update form id for form upload flow #34503
Conversation
3147a2f
to
ea52a2d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Nice work Jacob! My comments are mostly just questions from curiosity but I do think it might be worth revisiting what we enter for benefit
. Maybe glean something from the form title or subtitle to figure out what benefit it is conferring? 🤔
benefit: `form upload flow`, | ||
title: `form 21P-0518-1 upload`, | ||
description: 'uploaded file for form 21P-0518-1', | ||
trackingPrefix: 'form-21p-0518-1-upload-', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want benefit
for each to be different? What does benefit
go to or mean? Maybe it should just repeat whatever's in title
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question, I can make the update and determine a good answer for you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it's used to generate and display applications in progress within the ApplicationsInProgress.jsx component.
ea52a2d
to
264ba3b
Compare
264ba3b
to
803f2bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
Summary
-UPLOAD
as the form id in order to support multiple form uploads at a time.Related issue(s)
Testing done
What areas of the site does it impact?
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
Requested Feedback
Any