Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MHV-65333 + MHV-66798: Rx updates to Print/PDF/TXT #34510

Merged
merged 4 commits into from
Feb 6, 2025

Conversation

vmenshutin-bylight
Copy link
Contributor

@vmenshutin-bylight vmenshutin-bylight commented Feb 5, 2025

Summary

  1. Updated medications PDF template
  2. Updated Print view, PDF and TXT generation for Rx List and Details pages

Related issue(s)

https://jira.devops.va.gov/browse/MHV-65333
https://jira.devops.va.gov/browse/MHV-66798

Examples:

VA-medications-details-null-2-5-2025 (5).pdf
VA-medications-details-null-2-5-2025 (7).txt

Figma file:

https://www.figma.com/design/brTf5ZBdG6gn3hop0yvrjU/Medications-Phase-1?node-id=13352-108515&t=UWwA1fcJWay8c27t-0

Testing done

  • Unit testing
  • Manual testing

What areas of the site does it impact?

/my-health/medications

Acceptance criteria

AC1: Change: Reorder fields for “About your prescription”
matches order on Medications Details mockup
AC2: Remove: “Note:...” after Status
AC3: Add: “Previous prescriptions associated with this medication” field
remove section when there are no previous prescriptions
AC4: Remove: “About this medication or supply” header
remove divider after header
AC5: Change: header from “About your prescription” to “Most recent prescription”
AC6: Remove: Dividers between refills
AC7: Add: “Previous prescription” as H3
AC8: Add: “Prescription number:...” as H4
include last filled, quantity, prescribed on, and prescribed by fields
AC9: Remove: Dividers between allergies
AC10: Change: Content change from “Older prescriptions” to “Previous prescriptions”

AC1: Header from “About your prescription” to “Most recent prescription”
“Most recent prescription” h3 and following fields in the section should be not be indented
AC2: Change: “Refill history” is an h4
Fields below this header should be indented and left aligned with the “Refill: Month DD, YYYY” fields
AC3: Change: “Shipped on” field is only included in the most recent entry of the refill history, applying to refills, partial fills, and original fill. This applies for the UI and pdf/txt files
AC4: Note: We should be using the content "Original fill" instead of "First fill"
AC5: Change: “Showing # refills from newest to oldest” with total number of refills
Change content to “Showing 1 refill” when there is only one
AC6: Change: All “Refill: Month DD, YYYY” headers are h5 and contain the filled on date
AC7: Note: The order of the refill history should be from newest to oldest last filled date across the UI and pdf/txt files
AC8: Change: “Showing # prescriptions from newest to oldest” with total number of prescriptions
Change content to “Showing 1 prescription” when there is only one
AC9: Change: “Allergy name” is an h3
Should not be indented
AC10: Change: “Non-VA Medication name + strength + form” h2 and following fields in the section should not be indented
AC11: Change: “Allergy name” is an h3
Fields below this header should not be indented
AC12: Change: Remove line break between “Try again later” and “If it still ...” so there are no breaks between sentences

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

@va-vfs-bot va-vfs-bot temporarily deployed to master/MHV-65333-grouping-pdf/main February 5, 2025 06:00 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/MHV-65333-grouping-pdf/main February 5, 2025 06:56 Inactive
@vmenshutin-bylight vmenshutin-bylight marked this pull request as ready for review February 5, 2025 07:22
@vmenshutin-bylight vmenshutin-bylight requested review from a team as code owners February 5, 2025 07:22
@va-vfs-bot va-vfs-bot temporarily deployed to master/MHV-65333-grouping-pdf/main February 5, 2025 07:23 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/MHV-65333-grouping-pdf/main February 5, 2025 22:16 Inactive
Copy link
Contributor

@rmessina1010 rmessina1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmenshutin-bylight vmenshutin-bylight merged commit a8e9ed3 into main Feb 6, 2025
83 checks passed
@vmenshutin-bylight vmenshutin-bylight deleted the MHV-65333-grouping-pdf branch February 6, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants