Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edm 602 lacp refactor #34513

Merged
merged 18 commits into from
Feb 7, 2025
Merged

Edm 602 lacp refactor #34513

merged 18 commits into from
Feb 7, 2025

Conversation

nicholashibbits
Copy link
Contributor

@nicholashibbits nicholashibbits commented Feb 5, 2025

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

⚠️ TeamSites ⚠️

Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the #sitewide-public-websites Slack channel for questions.

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

  • Major refactor of License and Certifications Search page ahead of usability research.
  • Education Data Migration (EDM)
  • These changes are behind a feature toggle, to be lifted when the contract expires in April.

Related issue(s)

  • EDM-602: update UI

Testing done

  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected
  • Describe the tests completed and the results
  • _Exclusively stating 'Specs and automated tests passing' is NOT acceptable as appropriate testing
  • Optionally, provide a link to your test plan and test execution records

Screenshots

Screenshot 2025-02-05 at 2 58 38 PM Screenshot 2025-02-05 at 2 58 00 PM Screenshot 2025-02-06 at 2 24 11 PM | Mobile | Screenshot 2025-02-06 at 2 23 50 PM

What areas of the site does it impact?

Comparison Tool

Acceptance criteria

Quality Assurance & Testing

  • Unit testing and linting error will be accounted for in a later PR.
  • Merging these changes in so my teams QA engineer can perform her tests before usability research commences.

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

No authentication required for these changes

@va-vfs-bot va-vfs-bot temporarily deployed to master/EDM-602-lacp-refactor/main February 5, 2025 15:23 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/EDM-602-lacp-refactor/main February 5, 2025 21:39 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/EDM-602-lacp-refactor/main February 5, 2025 22:26 Inactive
@nicholashibbits nicholashibbits requested a review from binq February 5, 2025 22:27
@va-vfs-bot va-vfs-bot temporarily deployed to master/EDM-602-lacp-refactor/main February 5, 2025 22:54 Inactive
@nicholashibbits nicholashibbits marked this pull request as ready for review February 5, 2025 23:25
@nicholashibbits nicholashibbits requested review from a team as code owners February 5, 2025 23:25
Copy link

@va-vfs-bot va-vfs-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint is disabled

vets-website uses ESLint to help enforce code quality. In most situations we would like ESLint to remain enabled.

What you can do

See if the code can be refactored to avoid disabling ESLint, or wait for a VSP review.


return (
<h2 className={headerClasses}>
{/* eslint-disable-next-line @department-of-veterans-affairs/prefer-button-component, react/button-has-type */}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint disabled here

rmessina1010
rmessina1010 previously approved these changes Feb 6, 2025
Copy link
Contributor

@rmessina1010 rmessina1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@binq binq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicholashibbits nicholashibbits merged commit 7001775 into main Feb 7, 2025
79 checks passed
@nicholashibbits nicholashibbits deleted the EDM-602-lacp-refactor branch February 7, 2025 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants