Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All claims 23 mg #8705

Merged
merged 11 commits into from
Oct 10, 2018
Merged

All claims 23 mg #8705

merged 11 commits into from
Oct 10, 2018

Conversation

markgreenburg
Copy link
Contributor

@markgreenburg markgreenburg commented Oct 9, 2018

Description

Adds more options to the follow-up questions for new disabilities.

Note: This PR doesn't include the disability name in the title of the follow-up questions, because this isn't supported by the forms library for string fields. Opened an issue for this in the forms repo.

Testing done

  • Tested locally
  • Unit tests

Screenshots

First option / new primary disability:
screen shot 2018-10-09 at 12 05 27 pm


Second option / new secondary disability:
screen shot 2018-10-09 at 12 05 53 pm


Third option / new worsened disability:
screen shot 2018-10-09 at 12 06 18 pm


Fourth option / new va mistreatment disability:
screen shot 2018-10-09 at 12 06 52 pm


PTSD:
screen shot 2018-10-09 at 12 05 19 pm

Acceptance criteria

  • Sorts PTSD-related disabilities to the end of the flow
  • Updates follow-up options per content in attached ticket
  • Updates follow-up questions for each follow-up option in the ticket
  • All follow-up questions conditionally required based on option selected
  • PTSD gets its own info page, PTSD form to be tackled in another PR

Definition of done

  • Events are logged appropriately
  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue (or connected to it via ZenHub)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

@va-bot va-bot temporarily deployed to vetsgov-pr-8705 October 9, 2018 17:11 Inactive
Copy link
Contributor

@peggygannon peggygannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markgreenburg Hi! Screenshots look good..(I have no edits!). However, i didn't see a screenshot for the

  • Service-connected disability pop up box
  • Summary of disabilities screen
    PTSD claims
    { INSERT BAH 0781 FLOW HERE }
    X of Y Disabilities
    Summary of disabilities
    Below is the list of disabilities you're claiming in this application. If a disability is missing from the list, please go back one screen and add it.
    {list of disabilities}

// before the next item is evaluated (e.g., if PTSD was entered first,
// it would still show first even though the first page was skipped).
// This break between the two `showPagePerItem`s ensures PTSD is sorted
// behind non-PTSD conditions in the form flow.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great comment!

itemFilter: item => !ptsdDisabilityIds.has(item.diagnosticCode),
itemFilter: item =>
item.condition
? !item.condition.toLowerCase().includes(PTSD)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively: itemFilter: item => item.condition && !item.condition.toLowerCase().includes(PTSD)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, good call

showPagePerItem: true,
itemFilter: item =>
item.condition
? item.condition.toLowerCase().includes(PTSD)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively: itemFilter: item => item.condition && item.condition.toLowerCase().includes(PTSD)

@markgreenburg
Copy link
Contributor Author

markgreenburg commented Oct 9, 2018

Thanks for catching that @peggygannon - below are screenshots of the modal and the summary page.
The PTSD follow-up page with the 781 questions needs to be added during the integration step, so I've left it off this PR. The PTSD info page is still in here, though, with screenshots in the original PR comment.

Disabilities Summary:
screen shot 2018-10-09 at 4 50 24 pm


Service-connected modal:
screen shot 2018-10-09 at 3 38 13 pm

@va-bot va-bot temporarily deployed to vetsgov-pr-8705 October 9, 2018 22:20 Inactive
@markgreenburg markgreenburg changed the title [WIP] All claims 23 mg All claims 23 mg Oct 9, 2018
@va-bot va-bot temporarily deployed to vetsgov-pr-8705 October 9, 2018 22:24 Inactive
@va-bot va-bot temporarily deployed to master/all-claims-23-mg October 9, 2018 23:16 Inactive
@peggygannon
Copy link
Contributor

@markgreenburg Thanks for posting the other screenshots. LGTM

@markgreenburg markgreenburg merged commit 1671b0e into master Oct 10, 2018
@markgreenburg markgreenburg deleted the all-claims-23-mg branch October 10, 2018 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants