-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All claims 23 mg #8705
All claims 23 mg #8705
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markgreenburg Hi! Screenshots look good..(I have no edits!). However, i didn't see a screenshot for the
- Service-connected disability pop up box
- Summary of disabilities screen
PTSD claims
{ INSERT BAH 0781 FLOW HERE }
X of Y Disabilities
Summary of disabilities
Below is the list of disabilities you're claiming in this application. If a disability is missing from the list, please go back one screen and add it.
{list of disabilities}
// before the next item is evaluated (e.g., if PTSD was entered first, | ||
// it would still show first even though the first page was skipped). | ||
// This break between the two `showPagePerItem`s ensures PTSD is sorted | ||
// behind non-PTSD conditions in the form flow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great comment!
itemFilter: item => !ptsdDisabilityIds.has(item.diagnosticCode), | ||
itemFilter: item => | ||
item.condition | ||
? !item.condition.toLowerCase().includes(PTSD) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively: itemFilter: item => item.condition && !item.condition.toLowerCase().includes(PTSD)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah, good call
showPagePerItem: true, | ||
itemFilter: item => | ||
item.condition | ||
? item.condition.toLowerCase().includes(PTSD) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively: itemFilter: item => item.condition && item.condition.toLowerCase().includes(PTSD)
Thanks for catching that @peggygannon - below are screenshots of the modal and the summary page. |
@markgreenburg Thanks for posting the other screenshots. LGTM |
Description
Adds more options to the follow-up questions for new disabilities.
Note: This PR doesn't include the disability name in the title of the follow-up questions, because this isn't supported by the forms library for string fields. Opened an issue for this in the forms repo.
Testing done
Screenshots
First option / new primary disability:
Second option / new secondary disability:
Third option / new worsened disability:
Fourth option / new va mistreatment disability:
PTSD:
Acceptance criteria
Definition of done