Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sorbet typecheck under python module on 5 files #11261

Merged
merged 40 commits into from
Jan 17, 2025
Merged
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
5b13200
Added sorbet typecheck under python module for setup_file_parser.rb ,…
randhircs Jan 9, 2025
86a31e6
Fixed issue in index_finder
randhircs Jan 9, 2025
8df8696
Fixed issue in setupfilesanitizer
randhircs Jan 9, 2025
2057bef
Included TypeCheck for one more file
randhircs Jan 9, 2025
a43fc93
Remvoed from index finder file
randhircs Jan 9, 2025
271aeb9
Removed from pyproject_preparer
randhircs Jan 10, 2025
ecaa4d2
Commented since return type is not correct
randhircs Jan 10, 2025
4c981af
Added TypeCheck back to setup_file_parser
randhircs Jan 10, 2025
a383d86
Added TypeCheck pyproject_preparer.rb
randhircs Jan 10, 2025
cfc5044
Removed commented code
randhircs Jan 10, 2025
a8d8ad5
Added TypeCheck as strict for file_parser
randhircs Jan 13, 2025
604024f
Added TypeCheck as strict for file_parser
randhircs Jan 13, 2025
711a96f
Removed nilable to fix the issue
randhircs Jan 14, 2025
44d27cc
Moved back to untyped
randhircs Jan 14, 2025
e0e0646
Moved back to untyped
randhircs Jan 14, 2025
d9320d2
Moved back to untyped
randhircs Jan 14, 2025
85d266a
corrected return type
randhircs Jan 14, 2025
2955a64
Corrected returntype to pass end to end error
randhircs Jan 14, 2025
4f38439
Changed requirementfile method return type
randhircs Jan 14, 2025
b847188
Changed return type to dependabotset
randhircs Jan 14, 2025
e03d781
Changed return type to dependencySet
randhircs Jan 14, 2025
12d3f3d
Corrected log_if_version_malformed
randhircs Jan 14, 2025
ee979f9
Changed return type in pipenv_runner
randhircs Jan 14, 2025
90772e1
Corrected return type
randhircs Jan 15, 2025
db2df60
Added TypeCheck as strict for pipenv_runner
randhircs Jan 15, 2025
ed5a286
Changed param DependcyFile Nilable
randhircs Jan 15, 2025
4aab29f
Changed setup file typecheck as strict
randhircs Jan 16, 2025
7cdf83b
Added files with typecheck strict
randhircs Jan 16, 2025
2a539e6
Removed typecheck form pyproject_preparer file
randhircs Jan 16, 2025
d8e59c3
To fix removed hash
randhircs Jan 16, 2025
136d3c1
Added removed typo error
randhircs Jan 16, 2025
2dbfed7
Removed typecheck form setup_file_sanitixer
randhircs Jan 16, 2025
57952cf
Reverted back setup_file_sanitizer
randhircs Jan 16, 2025
cf4a42c
Reverted back setup_file_sanitizer
randhircs Jan 16, 2025
27b91c4
Reverted back setup_file_sanitizer
randhircs Jan 16, 2025
5842b20
Pulled back
randhircs Jan 16, 2025
2aa3992
Reduced untyped
randhircs Jan 16, 2025
e2b06be
Reduced untyped
randhircs Jan 16, 2025
d6806d1
Reduced untyped in pyproject_files_parser
randhircs Jan 16, 2025
64be557
Reduced untyped in pyproject_files_parser
randhircs Jan 16, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
To fix removed hash
randhircs committed Jan 17, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit d8e59c392cf6f5f7bf757acae78ebffc9304d684
Original file line number Diff line number Diff line change
@@ -68,11 +68,11 @@ def setup_requires_array

dep.name + dep.requirements.first[:requirement].to_s
end
end
ends

sig { returns(T::Hash[T.untyped, T.untyped]) }
sig { returns(T.untyped) }
def extras_require_hash
@extras_require_hash = T.let(T.untyped, T.untyped)
@extras_require_hash = T.let(Hash, T.untyped)
@extras_require_hash ||=
begin
hash = {}