-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for path based tag structure in github_actions module for monorepo structures. #11286
Support for path based tag structure in github_actions module for monorepo structures. #11286
Conversation
I did dry run, here is results. working as expected.
|
cc: @potiuk @assignUser |
Thanks @gopidesupavan , we'll try to see how we can get this in this week. |
Nice ! Will be super useful to keep all the Apache Software Foundation's actions to be kept in a single monorepo ! |
@gopidesupavan |
e688b3d
to
0f48552
Compare
@randhircs Thanks for review, have rebased looks good now :) |
0f48552
to
01c6540
Compare
01c6540
to
f579d7d
Compare
f579d7d
to
5463710
Compare
🎉 🙇♂️ |
Wooho thank you @randhircs 😄 |
What are you trying to accomplish?
Adding support to path based like tag structure for github_actions dependaboat module.
What: Adding support for path-based tag structures in the github_actions Dependabot module.
Why: Currently, Dependabot's github_actions module supports monorepo action bumps at the repository level. However, it does not work when a monorepo contains multiple actions, and the actions are tagged based on their paths.
At Apache Software Foundation, we are working on implementing organization-wide common actions in a single repository. For example, our current actions can be found here: https://github.com/apache/infrastructure-actions/. The plan is to structure tags based on action paths. This change will enable Dependabot to properly bump these actions, benefiting multiple projects that use them.
examples: We want tag action in this pattern
restore/v1.0.0
so this can be referred in workflows apache/infrastructure-actions/stash/restore@restore/v1.0.0Anything you want to highlight for special attention from reviewers?
The approach I've taken here is to name the dependency variable using the full action path whenever dealing with path-based tags.
Why is this necessary?
In the updater check flow, memorized filter results are used. This can lead to issues in repositories with path-based tags, as there's a chance of losing tag information when filtering eligible versions.
IMHO, we should treat path-based tags as an entirely new dependency section within the dependency set.
I could see one issue already created for this kind similar ask. #8451 it is trying to bump wrongly here.
I hope this can be solved.
How will you know you've accomplished your goal?
Checklist