Adding PNPM catalog protocol support #11418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
robaiken
force-pushed
the
robaiken/add-pnpm-catalog-protocol-support
branch
from
83e1664 to
c5691f2
Compare
sachin-sandhu
previously approved these changes
Jan 29, 2025
markhallen
reviewed
Jan 29, 2025
npm_and_yarn/spec/dependabot/npm_and_yarn/file_updater/pnpm_workspace_updater_spec.rb
Outdated
Show resolved
Hide resolved
npm_and_yarn/lib/dependabot/npm_and_yarn/file_updater/pnpm_workspace_updater.rb
Outdated
Show resolved
Hide resolved
robaiken
force-pushed
the
robaiken/add-pnpm-catalog-protocol-support
branch
from
1e351d9 to
6205232
Compare
markhallen
approved these changes
Jan 29, 2025
added create_workspace_dependency
robaiken
force-pushed
the
robaiken/add-pnpm-catalog-protocol-support
branch
from
bfa16a9 to
494c2fa
Compare
sachin-sandhu
approved these changes
Jan 29, 2025
sachin-sandhu
pushed a commit
that referenced
this pull request
Jan 31, 2025
* adding pnpm catalog protocol support * adding feature flag * fixing lint for yaml file * adding catalog experiment to tests * adding pnpm_workspace method to get workspace file * removing exception * adding sorbet typing * disabling class length cop * moving yarn workspace fixture to pnpm * Adding tests cases to file parser and updater * adding typing to enable_pnpm_workspace_catalog? * fixing test fixtures * lint * moving rubocop disable * removing unneeded imports added create_workspace_dependency * refactoring `create_dependency` function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Adding support for pnpm's catalog versioning system in Dependabot's core update logic. This allows Dependabot to track and update versions defined in
pnpm-workspace.yamlunder catalog keys.Currently, Dependabot doesn't detect version updates for packages defined in catalog sections. This change enables Dependabot to:
Anything you want to highlight for special attention from reviewers?
The core complexity is handling the source of truth for versions - catalog entries in
pnpm-workspace.yamltake precedence overpackage.jsonversions. Also focused on maintaining lock file integrity during updates.How will you know you've accomplished your goal?
Checklist