Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sorbet] - Add Typings for updater/lib/dependabot/updater/error_handler.rb #11429

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

kbukum1
Copy link
Contributor

@kbukum1 kbukum1 commented Jan 29, 2025

What are you trying to accomplish?

This change adds Sorbet typings to the ErrorHandler class within the Dependabot::Updater module. The goal is to ensure that type safety is maintained, especially when dealing with error handling and extracting the fingerprint from errors.

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

  • The code has been refactored to be type-safe with Sorbet, eliminating reliance on unsafe casts.
  • The functionality for error handling and fingerprint extraction should remain unchanged, ensuring the correct error details are logged and captured.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@kbukum1 kbukum1 self-assigned this Jan 29, 2025
@kbukum1 kbukum1 marked this pull request as ready for review January 29, 2025 22:52
@kbukum1 kbukum1 requested a review from a team as a code owner January 29, 2025 22:52
Copy link
Member

@randhircs randhircs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TMLG

@JamieMagee JamieMagee added the sorbet 🍦 Relates to Sorbet types label Jan 29, 2025
@kbukum1 kbukum1 merged commit 42d95a2 into main Jan 29, 2025
128 of 130 checks passed
@kbukum1 kbukum1 deleted the kamil/add-sorbet-typings-to-error-handler branch January 29, 2025 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sorbet 🍦 Relates to Sorbet types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants