Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

beforerequest as method #22

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

beforerequest as method #22

wants to merge 6 commits into from

Conversation

emilkoto
Copy link

Checked!

@andreialecu andreialecu requested a review from rgolea January 10, 2018 14:55
rgolea
rgolea reviewed Jan 10, 2018
View reviewed changes
index.js Outdated
} else if (ctx.method === "HEAD" && this.events.head) {
this.events.head.run(ctx, domain, function (err) {
ctx.done();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emilkoto you need to apply the parameters properly here ctx.done(err, result) or whatever you might need here.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emilkoto I think it would be ctx.done(err, '');

@fotoflo
Copy link

fotoflo commented Jun 17, 2019

Hello, any reason this has not merged yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgolea rgolea rgolea left review comments

@cristianfd cristianfd cristianfd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emilkoto @fotoflo @cristianfd @rgolea