Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent creating duplicate machine ids #116

Merged
merged 2 commits into from
Nov 5, 2024
Merged

fix: prevent creating duplicate machine ids #116

merged 2 commits into from
Nov 5, 2024

Commits on Nov 5, 2024

  1. fix: prevent creating duplicate machine ids 

    We saw the same machine id created more than one time.
This caused an issue where the cli would not be able
to connect to the correct machine.

We now wait for the instance to be created.
We don't care about what state the instance is in
only that it has been handled by AWS.

We believe duplication would happen when the scheduleTask
would finish quickly, receive the next update from the API,
but without AWS reporting the machine as pending.

Co-authored-by: Billy Batista <[email protected]>
Signed-off-by: Chris Goller <[email protected]>
    @goller @billyb2
    goller and billyb2 committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    4d02a9c View commit details
    Browse the repository at this point in the history

  2. refactor: use aws waiters 

    Signed-off-by: Chris Goller <[email protected]>
    @goller
    goller committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    ffc5a68 View commit details
    Browse the repository at this point in the history