[DesignKit] 파일 생성및 리소스 파일 생성 #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Color asset 추가 및 다이나믹 framework로 변경
junlight94
reviewed
Feb 9, 2025
Comment on lines
+12
to
+19
| public struct DPUI<Base> { | ||
|
|
||
| public let base: Base | ||
|
|
||
| public init(_ base: Base) { | ||
| self.base = base | ||
| } | ||
| } |
There was a problem hiding this comment.
DP는 디프만 약자인가요?? DPUI가 뭐지 하고 찾아봤습니다 네이밍 관련해서 조금 논의해보고 가는 것도 좋을 것 같아요
There was a problem hiding this comment.
네이밍은 변경이 필요한거같애 아직 서비스 이름이 나오지 않아서 일단 쓰긴했는데 같이 논의해서 변경해도될거같애 ㅎㅎ 구조는 어떻게 생각해??
There was a problem hiding this comment.
구조는 좋은 것 같아 UIColor, Color 사용하는 쪽에서 접근 방법이 명확해서 헷갈릴 일이 없을 것 같아 👍
junlight94
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Color asset 추가 및 다이나믹 framework로 변경
변경 유형
변경 사항
DPUI 코드 추가, rx를 사용하는것처럼, UIColor.dpUI.background, Color.dpUI.background등 dpUI를 통해서 사용하여 중간 depdency를 추가하는 작업
시작 코드 참조,
DesigneKit을 staticframework에서 dynamicframework로 변경, 리소스 파일을 참조하고, 전역적으로 사용하는 구조라 다이나믹이 필요한 것으로 판단,
관련링크 (JIRA)
관련 로그, 스크린샷