Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 소식페이지에서 응원 이후 해당 기록 상세 페이지로 이동 #382

Merged
merged 1 commit into from
Sep 6, 2024
Merged

feat: 소식페이지에서 응원 이후 해당 기록 상세 페이지로 이동 #382

merged 1 commit into from
Sep 6, 2024

Conversation

hjy0951
Copy link
Collaborator

@hjy0951 hjy0951 commented Sep 5, 2024 •
edited
Loading

🤔 어떤 문제가 발생했나요?

  • 소식 페이지에서 응원 이후 페이지 이동이 없으니 기능 오류 같다는 피드백을 받았습니다.

🎉 어떻게 해결했나요?

  • 응원 이후 해당 기록 상세 페이지로 이동하도록 수정하였습니다.

📷 이미지 첨부 (Option)

2024-09-05.6.22.55.mov

⚠️ 유의할 점! (Option)

@king2dwellsang king2dwellsang added Review Plz🙏 # Review is not yet complete feat # Add feature labels Sep 5, 2024
wokbjso
wokbjso approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@wokbjso wokbjso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿입니다~~

@hjy0951 hjy0951 merged commit ada1412 into main Sep 6, 2024
8 checks passed
@hjy0951 hjy0951 deleted the feat/move-detail-after-cheer-in-news branch September 6, 2024 05:47
@king2dwellsang king2dwellsang added Approved 🆗 # Review is completed and removed Review Plz🙏 # Review is not yet complete labels Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wokbjso wokbjso wokbjso approved these changes

@Jungjjeong Jungjjeong Awaiting requested review from Jungjjeong Jungjjeong is a code owner

@summermong summermong Awaiting requested review from summermong summermong is a code owner

Assignees

@hjy0951 hjy0951

Labels
Approved 🆗 # Review is completed feat # Add feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hjy0951 @wokbjso @king2dwellsang