[Feature/Room] Implement random profile generation #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ture/random-profile # Conflicts: # kok-api/src/main/java/com/kok/kokapi/room/application/service/RandomProfileService.java # kok-api/src/main/java/com/kok/kokapi/room/application/service/RoomParticipantService.java
|
편하실때 리뷰 부탁드려요~! |
linirini
approved these changes
Mar 8, 2025
kok-api/src/main/java/com/kok/kokapi/room/adapter/in/dto/response/RoomDetailResponse.java
Outdated
Show resolved
Hide resolved
kok-api/src/main/java/com/kok/kokapi/room/adapter/in/web/RoomProfileController.java
Outdated
Show resolved
Hide resolved
kok-api/src/main/java/com/kok/kokapi/room/adapter/out/persistence/RoomMemberQueryAdapter.java
Outdated
Show resolved
Hide resolved
kok-core/src/main/java/com/kok/kokcore/room/application/port/out/LoadRoomMemberPort.java
Outdated
Show resolved
Hide resolved
kok-core/src/main/java/com/kok/kokcore/room/usecase/CreateRoomUseCase.java
Outdated
Show resolved
Hide resolved
kok-api/src/main/java/com/kok/kokapi/room/adapter/in/web/RoomController.java
Show resolved
Hide resolved
...i/src/main/java/com/kok/kokapi/room/adapter/out/persistence/RoomParticipantQueryAdapter.java
Outdated
Show resolved
Hide resolved
minseokey
approved these changes
Mar 8, 2025
| private final ObjectMapper objectMapper; | ||
|
|
||
| @Override | ||
| public void joinRoom(String roomId, Member member) { |
There was a problem hiding this comment.
이 지점에서 memberId 를 리턴해주는것이 좋을것 같다는 의견입니다!
There was a problem hiding this comment.
우선 여기에서 memberId를 리턴하는 방식으로 수정했어요
|
다 수정했어요 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
📝 작업 내용
📸 스크린샷 (선택)
💬 리뷰 요구사항(선택)