-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 최근 접속 시간 조회 기능 구현 #267
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikekks
reviewed
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다 ~! 궁금한 부분은 리뷰 남겼습니다 !! :)
layer-api/src/main/java/org/layer/aop/RecentAccessHistoryAop.java
Outdated
Show resolved
Hide resolved
layer-admin/src/main/java/org/layer/member/service/AdminMemberService.java
Outdated
Show resolved
Hide resolved
layer-admin/src/main/java/org/layer/member/controller/dto/GetMemberActivityResponse.java
Show resolved
Hide resolved
layer-admin/src/main/java/org/layer/member/service/AdminMemberService.java
Outdated
Show resolved
Hide resolved
mikekks
approved these changes
Dec 11, 2024
mikekks
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생많으셨습니다 !!
clean2001
added a commit
that referenced
this pull request
Dec 11, 2024
* feat: 최근 접속 시간 조회 기능 구현 * chore: GetMemberActivityResponse에서 변수명 수정 * chore: RedisConfig 통합 및 objectMapper 관련 변경 * chore: RecentActivityDto 생성 및 적용 * chore: dev, prod에 redis 컨테이너 추가 * chore: infra > development > redis.conf 추가 * fix: dev > docker-compose.yaml volume 정보 * fix: redis에도 network 정보 추가 * fix: dev > nginx.conf 수정 --------- Co-authored-by: mikekks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 PR 타입
📢 변경 사항
api 모듈
admin 모듈
recentActivityDate
를 레디스에 저장된 값으로 수정했습니다.❗️To Reviewer
⚙️ 테스트 결과
4번 유저로 요청 보내고 레디스의 2번 db에 저장된 값
api 응답 값
발생한 쿼리 첨부
👉 반영 브랜치