Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(styles): secondary disabled button background color #1808

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from
Draft

fix(styles): secondary disabled button background color #1808

wants to merge 6 commits into from

Conversation

anastasialanz
Copy link
Contributor

@anastasialanz anastasialanz commented Feb 20, 2025 •
edited
Loading

Fixes #1807

The secondary button disabled background color should use --gray-20.

@aws-amplify-us-east-1 AWS Amplify (us-east-1)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1808.d15792l1n26ww3.amplifyapp.com

@anastasialanz anastasialanz marked this pull request as ready for review February 20, 2025 22:44
@anastasialanz anastasialanz requested a review from a team as a code owner February 20, 2025 22:44
scurker
scurker requested changes Feb 20, 2025
View reviewed changes
Copy link
Member

@scurker scurker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshots should be updated (I'm surprised this didn't fail). Do you mind taking a look?

@anastasialanz
Copy link
Contributor Author

anastasialanz commented Feb 21, 2025 •
edited
Loading

Screenshots should be updated (I'm surprised this didn't fail). Do you mind taking a look?

I haven't fully dug into why they pass with yarn screenshots but they do fail using the VS Code Playright extension. yarn screenshots --update-snapshots doesn't update any snapshots.

@anastasialanz anastasialanz marked this pull request as draft February 21, 2025 14:09
@anastasialanz anastasialanz mentioned this pull request Mar 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scurker scurker scurker requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update disabled style for the secondary button
2 participants
@anastasialanz @scurker