adding cancelable launch prompts to NodeShell #2360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what it looks like now |
derailed
reviewed
Dec 24, 2023
There was a problem hiding this comment.
@wjiec Nice! Thank you for this cool upgrade Jayson!
Small pick no sure about the naming here as we are not really prompting?
Perhaps progress or cancelable might be good.
For the future it could be cool to show progress ie x of y or a progress bar on this dialog.
| @@ -0,0 +1,57 @@ | |||
| package dialog | |||
There was a problem hiding this comment.
This is not really prompting. Perhaps progress or wait might be a better name?
Merged
thejoeejoee
pushed a commit
to thejoeejoee/k9s
that referenced
this pull request
Feb 23, 2024
placintaalexandru
pushed a commit
to placintaalexandru/k9s
that referenced
this pull request
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally when launching NodeShell the whole view would freeze until the shell was entered or the launch timed out (takes 100 seconds!).
This PR adds a launch prompt to NodeShell and can interrupt execution. It also reduces the wait time with more frequent checks.