Secrets are decoded upon describe #2461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
placintaalexandru
force-pushed
the
feat/Secrets-are-decoded
branch
from
6bb205e to
39dded6
Compare
derailed
reviewed
Jan 10, 2024
There was a problem hiding this comment.
@placintaalexandru Thank you Alexandru for taking this on!!
What you have here would be just fine with some TLC.
But wondering if this could be an opportunity to refactor and improve so we can build on in the future?
placintaalexandru
force-pushed
the
feat/Secrets-are-decoded
branch
from
eaafe5e to
59648d7
Compare
derailed
requested changes
Jan 18, 2024
There was a problem hiding this comment.
@placintaalexandru Thanks for these updates! Getting closer...
derailed
added
enhancement
placintaalexandru
force-pushed
the
feat/Secrets-are-decoded
branch
from
59648d7 to
c28764e
Compare
placintaalexandru
force-pushed
the
feat/Secrets-are-decoded
branch
2 times, most recently
from
b3140d1 to
df69476
Compare
derailed
requested changes
Jan 18, 2024
placintaalexandru
force-pushed
the
feat/Secrets-are-decoded
branch
from
df69476 to
e55bf94
Compare
derailed
approved these changes
Jan 19, 2024
thejoeejoee
pushed a commit
to thejoeejoee/k9s
that referenced
this pull request
Feb 23, 2024
placintaalexandru
added a commit
to placintaalexandru/k9s
that referenced
this pull request
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #373