Strict unmarshal for plugin files #3046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to improve the behaviour introduced in #2770.
The regular
Unmarshalfunction does not result in anerrwhen trying to unmarshal a yaml file that contains apluginskey into aPluginvar. TheUnmarshalStrictfunction will, since it finds the undefinedpluginskey, causing the next loop to actually trigger.I have also taken the liberty to make it look for plugins in the
XDG_DATA_HOMEandXDG_CONFIG_HOMEfolders. This is especially useful sinceXDG_DATA_HOMEis not included in theXDG_DATA_DIRSby default (as per https://specifications.freedesktop.org/basedir-spec/latest/#variables). This allows users to define per-user plugins in addition to the ones in/usr/local/share/:/usr/share/.