Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add margin to the icons in the "List" view #510

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Palollo
Copy link

@Palollo Palollo commented Jan 6, 2025

Now fixed to just 1 pixel to avoid icons touching each other,
but it can be made configurable in the future.

@derceg
Copy link
Owner

derceg commented Jan 6, 2025

Hi @Palollo, could you add some information about why this is needed? Screenshots showing the problem and how this fixes it might be useful. Thanks.

@Palollo
Copy link
Author

Palollo commented Jan 6, 2025

Hi, it is a subtle change, but makes the difference ;)
Before (it looks slovenly, the icons of files/folders are touching each other and the border of the window, there is no division or break between them):
imagen

After (looks nicer, clean, seemly, with just 1 pixel of margin, but it can be increased or even configurable by the user):
imagen

@derceg
Copy link
Owner

derceg commented Jan 20, 2025

The general idea here could work, but the implementation, as it exists right now, isn't workable. The list of icons needed isn't static, since items can be added to the directory after the navigation has completed. Trying to retrieve a list of all necessary icons up front isn't going to work for that reason.

This would have to work something more like thumbnails view, where the images are generated on-demand and the image list is destroyed whenever the view changes or a navigation occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants