Encode URL for lubcurl, such as spaces to %20 #780
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Curl requires RFC-3986 encoded Uniform Resource Identifiers (URI).
In particular there is a percent-encoding for characters such as space (%20)
I came across this limitation of feh by loading images via curl with space characters in their file name.
This change uses the libcurl URL parsing API to perform the appropriate encoding.
Sample debug logging for successful space-containing file name.
(This case fails for feh without this change)