Expose routingMode as query parameter #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derhuerst
reviewed
May 29, 2024
|
Your PR looks very good, I have just one minor request. Sorry it took me so long to look into this. |
derhuerst
reviewed
May 29, 2024
|
Glad to hear that. And no worries! I accepted your suggestions. |
derhuerst
reviewed
May 31, 2024
derhuerst
approved these changes
Aug 8, 2024
derhuerst
requested changes
Aug 8, 2024
Co-authored-by: Jannis R <[email protected]>
Co-authored-by: Jannis R <[email protected]>
Co-authored-by: Jannis R <[email protected]>
Escape backticks Co-authored-by: Jannis R <[email protected]>
JohannesGandhi
force-pushed
the
expose-routingMode
branch
from
e392335
to
46437b8
Compare
|
I rebased with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains the changes suggested in #31 (comment).
Fixes #31
related: #42
I didn't bump up the version number.