Fix qs bugs #354
Open
Fix qs bugs #354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…telist-check fix: removed the dotcom check
|
Preview Link: https://Fix--QS-bugs.bot-65f.pages.dev
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes across multiple files to improve the handling of dropdown states and popover visibility, as well as adjustments to configuration values in the bot builder.
Changes related to dropdown state and popover visibility:
src/components/shared_ui/input/input.tsx: AddedhandleFocusandhandleBlurfunctions to manage dropdown state and log dropdown state changes to the console. These functions replace the directonFocusandonBlurprops. [1] [2]src/components/shared_ui/popover/popover.tsx: Enhanced thePopovercomponent to handle safe zones and adjust its position dynamically based on the dropdown state. This includes adding safety margins and adjusting offsets for the popover content. [1] [2] [3]src/pages/bot-builder/quick-strategy/inputs/qs-input.tsx: Introduced state management for dropdown visibility and addedMutationObserverto detect dropdown state changes. Adjusted popover visibility based on the dropdown state. [1] [2] [3] [4] [5] [6]Configuration adjustments:
src/pages/bot-builder/quick-strategy/config.ts: Updated the minimum values forTAKE_PROFITandSTAKEconfigurations from 0.35 to 1. [1] [2]Styling changes:
src/pages/bot-builder/quick-strategy/form-wrappers/strategy-template-picker.scss: Added border styling and padding adjustments for thequill-input__wrapper__variant--outlineclass.