-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Akmal / feat: barrier field improvements #17088
Merged
vinu-deriv
merged 16 commits into
deriv-com:master
from
akmal-deriv:f-barrier-improvements
Oct 22, 2024
Merged
Akmal / feat: barrier field improvements #17088
vinu-deriv
merged 16 commits into
deriv-com:master
from
akmal-deriv:f-barrier-improvements
Oct 22, 2024
+97
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akmal-deriv
requested review from
nijil-deriv,
vinu-deriv,
wojciech-deriv,
ali-hosseini-deriv,
amina-deriv,
balakrishna-deriv,
farrah-deriv,
habib-deriv,
matin-deriv,
sandeep-deriv and
yashim-deriv
as code owners
October 7, 2024 07:37
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-akmal-deriv-f-barrier-improvements.binary.sx/ |
nijil-deriv
previously approved these changes
Oct 8, 2024
ahmadtaimoor-deriv
approved these changes
Oct 9, 2024
kate-deriv
reviewed
Oct 18, 2024
packages/trader/src/AppV2/Components/TradeParameters/Barrier/barrier-input.tsx
Show resolved
Hide resolved
kate-deriv
approved these changes
Oct 18, 2024
nijil-deriv
previously approved these changes
Oct 18, 2024
⏳ Generating Lighthouse report... |
kate-deriv
approved these changes
Oct 22, 2024
ahmadtaimoor-deriv
approved these changes
Oct 22, 2024
henry-deriv
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This feature introduces improvements to the barrier field, enhancing usability and accuracy when users interact with barrier inputs.
These improvements aim to provide a smoother and more reliable experience when users interact with barrier fields.