Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Akmal / feat: barrier field improvements #17088

Merged
merged 16 commits into from
Oct 22, 2024

Conversation

akmal-deriv
Copy link
Contributor

Changes:

This feature introduces improvements to the barrier field, enhancing usability and accuracy when users interact with barrier inputs.

  1. User Input Handling: Improve the handling of user inputs in the barrier field to prevent errors and allow more intuitive input methods.
  2. Validation Enhancements: Strengthen validation logic to ensure only valid values are accepted, reducing input errors and increasing reliability.
  3. User Experience: Refine the interface for barrier inputs to make the process more user-friendly and efficient.

These improvements aim to provide a smoother and more reliable experience when users interact with barrier fields.

Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 22, 2024 5:54am

Copy link
Contributor

github-actions bot commented Oct 7, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17088](https://github.com/deriv-com/deriv-app/pull/17088)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-akmal-deriv-f-barrier-improvements.binary.sx?qa_server=red.derivws.com&app_id=23835
    - **Original**: https://deriv-app-git-fork-akmal-deriv-f-barrier-improvements.binary.sx
- **App ID**: `23835`

Copy link
Contributor

github-actions bot commented Oct 7, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 28
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-akmal-deriv-f-barrier-improvements.binary.sx/

@coveralls
Copy link

coveralls commented Oct 7, 2024

Pull Request Test Coverage Report for Build 11453883539

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 33 of 36 (91.67%) changed or added relevant lines in 2 files are covered.
  • 2066 unchanged lines in 96 files lost coverage.
  • Overall coverage increased (+0.3%) to 53.756%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/trader/src/AppV2/Components/TradeParameters/Barrier/barrier-input.tsx 18 19 94.74%
packages/trader/src/AppV2/Components/TradeParameters/Barrier/barrier.tsx 15 17 88.24%
Files with Coverage Reduction New Missed Lines %
packages/bot-web-ui/src/pages/dashboard/announcements/config.tsx 1 80.0%
packages/account/src/Sections/Verification/ProofOfIdentity/onfido.jsx 1 5.56%
packages/account/src/Sections/Profile/PhoneVerification/verification-link-expired-modal.tsx 1 86.96%
packages/hooks/src/useStoreWalletAccountsList.ts 1 83.33%
packages/trader/src/AppV2/Hooks/useContractsForCompany.ts 1 90.65%
packages/wallets/src/components/DerivAppsSection/DerivAppsGetAccount.tsx 1 80.6%
packages/wallets/src/hooks/useWalletAccountSwitcher.ts 1 67.14%
packages/cashier/src/app-content.tsx 1 0.0%
packages/wallets/src/components/WalletListHeader/WalletListHeader.tsx 1 85.37%
packages/wallets/src/features/cfd/screens/EnterPassword/EnterPassword.tsx 1 83.13%
Totals Coverage Status
Change from base Build 11209169403: 0.3%
Covered Lines: 35077
Relevant Lines: 60687

💛 - Coveralls

nijil-deriv
nijil-deriv previously approved these changes Oct 8, 2024
nijil-deriv
nijil-deriv previously approved these changes Oct 18, 2024
Copy link
Contributor

Generating Lighthouse report...

@vinu-deriv vinu-deriv merged commit d7c7463 into deriv-com:master Oct 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants