-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DTRA-2034 / Kate / [DTrader-V2] Errors handling #17095
Merged
vinu-deriv
merged 20 commits into
deriv-com:master
from
kate-deriv:kate/DTRA-2034/add_modals
Oct 22, 2024
Merged
DTRA-2034 / Kate / [DTrader-V2] Errors handling #17095
vinu-deriv
merged 20 commits into
deriv-com:master
from
kate-deriv:kate/DTRA-2034/add_modals
Oct 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-kate-deriv-kate-dtra-2034addmodals.binary.sx/ |
nijil-deriv
reviewed
Oct 11, 2024
packages/trader/src/AppV2/Components/ServiceErrorSheet/__tests__/service-error-sheet.spec.tsx
Outdated
Show resolved
Hide resolved
packages/trader/src/AppV2/Components/ServiceErrorSheet/service-error-description.tsx
Outdated
Show resolved
Hide resolved
kate-deriv
dismissed stale reviews from vinu-deriv and akmal-deriv
via
October 11, 2024 09:40
7208a81
nijil-deriv
previously approved these changes
Oct 11, 2024
nijil-deriv
previously approved these changes
Oct 11, 2024
vinu-deriv
previously approved these changes
Oct 11, 2024
kate-deriv
dismissed stale reviews from vinu-deriv and nijil-deriv
via
October 16, 2024 07:57
0acc126
nijil-deriv
previously approved these changes
Oct 16, 2024
⏳ Generating Lighthouse report... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Screenshots: