Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DTRA-2034 / Kate / [DTrader-V2] Errors handling #17095

Merged
merged 20 commits into from
Oct 22, 2024

Conversation

kate-deriv
Copy link
Contributor

@kate-deriv kate-deriv commented Oct 7, 2024

Changes:

  • Refactored ServiceErrorSheet. Now 4 errors will be shown inside of ActionSheet (those, which require special action button): 'Start trading with us', 'Insufficient balance', 'Account verification required', 'Pending verification'.
  • Created ServicesErrorSnackbar. All the rest errors will be shown in a Snackbar component.
  • Removed error text from purchase button and connected with it logic.
  • Updated Quill UI library version as it contains new props for Snackbar.
  • Added tests

Screenshots:

Screenshot 2024-10-10 at 6 36 07 PM
Screenshot 2024-10-10 at 6 22 06 PM
Screenshot 2024-10-10 at 5 33 07 PM
Screenshot 2024-10-07 at 3 16 36 PM
Screenshot 2024-10-07 at 3 29 17 PM
Screenshot 2024-10-07 at 5 36 04 PM
Screenshot 2024-10-10 at 4 36 00 PM
Screenshot 2024-10-10 at 4 38 12 PM
Screenshot 2024-10-10 at 4 38 46 PM
Screenshot 2024-10-09 at 1 10 31 PM

Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 22, 2024 6:38am

Copy link
Contributor

github-actions bot commented Oct 7, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17095](https://github.com/deriv-com/deriv-app/pull/17095)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-kate-deriv-kate-dtra-2034addmodals.binary.sx?qa_server=red.derivws.com&app_id=32875
    - **Original**: https://deriv-app-git-fork-kate-deriv-kate-dtra-2034addmodals.binary.sx
- **App ID**: `32875`

Copy link
Contributor

github-actions bot commented Oct 7, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 30
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-kate-deriv-kate-dtra-2034addmodals.binary.sx/

@coveralls
Copy link

coveralls commented Oct 7, 2024

Pull Request Test Coverage Report for Build 11454359095

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 94 of 105 (89.52%) changed or added relevant lines in 11 files are covered.
  • 21 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.03%) to 53.774%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/core/src/Stores/contract-store.js 0 1 0.0%
packages/trader/src/AppV2/Components/PurchaseButton/purchase-button.tsx 6 7 85.71%
packages/trader/src/AppV2/Components/ServiceErrorSheet/service-error-description.tsx 9 10 90.0%
packages/core/src/Stores/contract-replay-store.js 0 2 0.0%
packages/core/src/Stores/portfolio-store.js 0 2 0.0%
packages/trader/src/AppV2/Components/ServiceErrorSheet/service-error-sheet.tsx 46 48 95.83%
packages/trader/src/AppV2/Components/TradeParameters/Stake/stake.tsx 1 3 33.33%
Files with Coverage Reduction New Missed Lines %
packages/core/src/Stores/contract-store.js 1 0.0%
packages/trader/src/AppV2/Components/TradeParameters/Strike/strike.tsx 1 87.88%
packages/trader/src/App/Components/Elements/market-countdown-timer.tsx 1 83.7%
packages/trader/src/AppV2/Components/TradeParameters/PayoutPerPoint/payout-per-point.tsx 1 87.88%
packages/trader/src/AppV2/Components/TradeParameters/Duration/duration.tsx 2 77.27%
packages/trader/src/AppV2/Components/TradeParameters/Stake/stake.tsx 5 87.61%
packages/trader/src/AppV2/Containers/Trade/trade-types.tsx 10 83.33%
Totals Coverage Status
Change from base Build 11438140284: 0.03%
Covered Lines: 35101
Relevant Lines: 60709

💛 - Coveralls

nijil-deriv
nijil-deriv previously approved these changes Oct 11, 2024
nijil-deriv
nijil-deriv previously approved these changes Oct 11, 2024
vinu-deriv
vinu-deriv previously approved these changes Oct 11, 2024
nijil-deriv
nijil-deriv previously approved these changes Oct 16, 2024
Copy link
Contributor

Generating Lighthouse report...

@vinu-deriv vinu-deriv merged commit cac1e0c into deriv-com:master Oct 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants