Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UPM1525] Suisin/chore: update content changes in password section #17108

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

suisin-deriv
Copy link
Contributor

@suisin-deriv suisin-deriv commented Oct 8, 2024

Changes:

update content changes in password section

Screenshots:

Screenshot 2024-10-21 at 6 07 35 PM
Screenshot 2024-10-21 at 5 54 14 PM

Copy link

vercel bot commented Oct 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 22, 2024 4:04am

@coveralls
Copy link

coveralls commented Oct 8, 2024

Pull Request Test Coverage Report for Build 11452683585

Details

  • 86 of 88 (97.73%) changed or added relevant lines in 8 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.001%) to 53.742%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/account/src/Sections/Security/Passwords/deriv-mt5-password.tsx 19 20 95.0%
packages/account/src/Sections/Security/Passwords/deriv-x-password.tsx 19 20 95.0%
Files with Coverage Reduction New Missed Lines %
packages/cfd/src/Containers/cfd-password-modal.tsx 1 74.95%
packages/trader/src/App/Components/Elements/market-countdown-timer.tsx 1 83.7%
Totals Coverage Status
Change from base Build 11439126147: 0.001%
Covered Lines: 35060
Relevant Lines: 60669

💛 - Coveralls

Copy link
Contributor

github-actions bot commented Oct 8, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17108](https://github.com/deriv-com/deriv-app/pull/17108)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-suisin-deriv-suisin-upm1525designchan-47249b.binary.sx?qa_server=red.derivws.com&app_id=24072
    - **Original**: https://deriv-app-git-fork-suisin-deriv-suisin-upm1525designchan-47249b.binary.sx
- **App ID**: `24072`

Copy link
Contributor

github-actions bot commented Oct 8, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 28
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-suisin-deriv-suisin-upm1525designchan-47249b.binary.sx/

Copy link
Contributor

github-actions bot commented Oct 22, 2024

Generating Lighthouse report...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants