Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WALL] george / WALL-4857 / Broken Server maintenance badge for MT5 Demo account on Transfer page #17238

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

heorhi-deriv
Copy link
Contributor

Changes:

  • fix broken Server maintenance badge for MT5 accounts on Transfer page
  • disable amount inputs if one of the accounts has Server maintenance or Unavailable status
  • hide balance for accounts that have Server maintenance or Unavailable status

Screenshots:

Screenshot 2024-10-17 at 16 59 56
Screenshot 2024-10-17 at 17 00 01

Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 22, 2024 6:55am

Copy link
Contributor

github-actions bot commented Oct 17, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17238](https://github.com/deriv-com/deriv-app/pull/17238)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-heorhi-deriv-wall-4857-broken-server-4956ee.binary.sx?qa_server=red.derivws.com&app_id=23811
    - **Original**: https://deriv-app-git-fork-heorhi-deriv-wall-4857-broken-server-4956ee.binary.sx
- **App ID**: `23811`

Copy link
Contributor

github-actions bot commented Oct 17, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 28
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-heorhi-deriv-wall-4857-broken-server-4956ee.binary.sx/

@coveralls
Copy link

coveralls commented Oct 17, 2024

Pull Request Test Coverage Report for Build 11454571692

Details

  • 24 of 28 (85.71%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.005%) to 53.737%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/api-v2/src/hooks/useTradingPlatformStatus.ts 0 4 0.0%
Totals Coverage Status
Change from base Build 11454172379: -0.005%
Covered Lines: 35049
Relevant Lines: 60656

💛 - Coveralls

jim-deriv
jim-deriv previously approved these changes Oct 18, 2024
nijil-deriv
nijil-deriv previously approved these changes Oct 21, 2024
@heorhi-deriv heorhi-deriv marked this pull request as draft October 21, 2024 06:57
@heorhi-deriv heorhi-deriv force-pushed the WALL-4857-Broken-Server-maintenance-badge-for-MT5-Demo-account-on-Transfer-page branch from 75237df to 17cdf1a Compare October 21, 2024 13:57
Copy link
Contributor

Generating Lighthouse report...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants