-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ahmad/trade type url param fix for reports #17268
Closed
ahmadtaimoor-deriv
wants to merge
14
commits into
deriv-com:master
from
ahmadtaimoor-deriv:f_redirection_reports
Closed
Ahmad/trade type url param fix for reports #17268
ahmadtaimoor-deriv
wants to merge
14
commits into
deriv-com:master
from
ahmadtaimoor-deriv:f_redirection_reports
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: livechat icon on testlinks * fix: country data for growthbook
* fix: add livechat widget call check * fix: whatsapp issue on freshchats * chore: pass country to growthbook on login using cloudflare check * fix: import issue * chore: added test case for getCountry * fix: test error
…deriv-com#17263) * fix: incorporated CSS changes * fix: issue with duplicate account
ahmadtaimoor-deriv
requested review from
nijil-deriv,
vinu-deriv,
wojciech-deriv,
ali-hosseini-deriv,
amina-deriv,
balakrishna-deriv,
farrah-deriv,
habib-deriv,
matin-deriv,
sandeep-deriv and
yashim-deriv
as code owners
October 21, 2024 07:55
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ahmadtaimoor-deriv
temporarily deployed
to
Preview
October 21, 2024 07:57
— with
GitHub Actions
Inactive
ahmadtaimoor-deriv
temporarily deployed
to
Preview
October 21, 2024 07:57
— with
GitHub Actions
Inactive
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-ahmadtaimoor-deriv-fredirectionreports.binary.sx/ |
ahmadtaimoor-deriv
changed the title
F redirection reports
Ahmad/trade type url param fix for reports
Oct 21, 2024
vinu-deriv
previously approved these changes
Oct 21, 2024
kate-deriv
approved these changes
Oct 21, 2024
ahmadtaimoor-deriv
requested review from
heorhi-deriv,
jim-deriv,
nada-deriv,
likhith-deriv and
dan-deriv
as code owners
October 21, 2024 08:05
… f_redirection_reports
ahmadtaimoor-deriv
dismissed
vinu-deriv’s stale review
October 21, 2024 08:12
The base branch was changed.
Pull Request Test Coverage Report for Build 11435952468Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
The redirection back from the report page is not selecting the correct trade type.
Screenshots:
Please provide some screenshots of the change.