Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ahmad/trade type url param fix for reports #17268

Conversation

ahmadtaimoor-deriv
Copy link
Contributor

@ahmadtaimoor-deriv ahmadtaimoor-deriv commented Oct 21, 2024

Changes:

The redirection back from the report page is not selecting the correct trade type.

Screenshots:

Please provide some screenshots of the change.

Copy link

vercel bot commented Oct 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 21, 2024 8:41am

Copy link
Contributor

github-actions bot commented Oct 21, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17268](https://github.com/deriv-com/deriv-app/pull/17268)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-ahmadtaimoor-deriv-fredirectionreports.binary.sx?qa_server=red.derivws.com&app_id=23851
    - **Original**: https://deriv-app-git-fork-ahmadtaimoor-deriv-fredirectionreports.binary.sx
- **App ID**: `23851`

Copy link
Contributor

github-actions bot commented Oct 21, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 31
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-ahmadtaimoor-deriv-fredirectionreports.binary.sx/

@ahmadtaimoor-deriv ahmadtaimoor-deriv changed the title F redirection reports Ahmad/trade type url param fix for reports Oct 21, 2024
vinu-deriv
vinu-deriv previously approved these changes Oct 21, 2024
@ahmadtaimoor-deriv ahmadtaimoor-deriv changed the base branch from rc_V20241015_0 to master October 21, 2024 08:12
@ahmadtaimoor-deriv ahmadtaimoor-deriv dismissed vinu-deriv’s stale review October 21, 2024 08:12

The base branch was changed.

@coveralls
Copy link

coveralls commented Oct 21, 2024

Pull Request Test Coverage Report for Build 11435952468

Details

  • 6 of 8 (75.0%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.002%) to 53.671%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/trader/src/Stores/Modules/Trading/trade-store.ts 3 5 60.0%
Files with Coverage Reduction New Missed Lines %
packages/cfd/src/Containers/cfd-password-modal.tsx 1 74.95%
Totals Coverage Status
Change from base Build 11434619004: -0.002%
Covered Lines: 34939
Relevant Lines: 60542

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants