Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Likhith/pr to master webrel 3250 #17271

Merged

Conversation

likhith-deriv
Copy link
Contributor

Changes:

Raising the fix of rc_V20241015 to master

Copy link

vercel bot commented Oct 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app 🛑 Canceled (Inspect) Oct 21, 2024 9:02am

Copy link
Contributor

github-actions bot commented Oct 21, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17271](https://github.com/deriv-com/deriv-app/pull/17271)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-likhith-deriv-likhith-pr-to-master-we-132229.binary.sx?qa_server=red.derivws.com&app_id=32920
    - **Original**: https://deriv-app-git-fork-likhith-deriv-likhith-pr-to-master-we-132229.binary.sx
- **App ID**: `32920`

Copy link
Contributor

github-actions bot commented Oct 21, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 30
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-likhith-deriv-likhith-pr-to-master-we-132229.binary.sx/

@coveralls
Copy link

coveralls commented Oct 21, 2024

Pull Request Test Coverage Report for Build 11436359421

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.004%) to 53.677%

Files with Coverage Reduction New Missed Lines %
packages/trader/src/AppV2/Utils/trade-params-utils.tsx 1 87.88%
Totals Coverage Status
Change from base Build 11434619004: 0.004%
Covered Lines: 34940
Relevant Lines: 60539

💛 - Coveralls

Copy link
Contributor

Generating Lighthouse report...

@shahzaib-deriv shahzaib-deriv merged commit c2e4973 into deriv-com:master Oct 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants