Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DTRA-V2] henry/dtra-2160/fix: call contracts for on landing company change #17297

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

henry-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 23, 2024 2:59am

Copy link
Contributor

github-actions bot commented Oct 23, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17297](https://github.com/deriv-com/deriv-app/pull/17297)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-henry-deriv-henry-reset-multiplier-wh-23112f.binary.sx?qa_server=red.derivws.com&app_id=32878
    - **Original**: https://deriv-app-git-fork-henry-deriv-henry-reset-multiplier-wh-23112f.binary.sx
- **App ID**: `32878`

Copy link
Contributor

github-actions bot commented Oct 23, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 34
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-henry-deriv-henry-reset-multiplier-wh-23112f.binary.sx/

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11471985967

Details

  • 3 of 6 (50.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.002%) to 53.801%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/trader/src/AppV2/Hooks/useContractsForCompany.ts 3 6 50.0%
Files with Coverage Reduction New Missed Lines %
packages/cfd/src/Containers/cfd-password-modal.tsx 1 74.95%
packages/trader/src/AppV2/Utils/trade-params-utils.tsx 1 86.8%
packages/trader/src/App/Components/Elements/market-countdown-timer.tsx 1 83.7%
Totals Coverage Status
Change from base Build 11461023064: -0.002%
Covered Lines: 35155
Relevant Lines: 60772

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants