Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEBREL-3262-Crypto-Wallets-Swiping-on-it's-own #17303

Conversation

maryia-matskevich-deriv
Copy link
Contributor

Changes:

Cherry-pick fix from rc_V20241017_0 to master

Screenshots:

Please provide some screenshots of the change.

Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 23, 2024 7:52am

Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17303](https://github.com/deriv-com/deriv-app/pull/17303)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-maryia-matskevich-deriv-webrel-3262-c-59d482.binary.sx?qa_server=red.derivws.com&app_id=23810
    - **Original**: https://deriv-app-git-fork-maryia-matskevich-deriv-webrel-3262-c-59d482.binary.sx
- **App ID**: `23810`

@maryia-matskevich-deriv maryia-matskevich-deriv merged commit 4db2d1c into deriv-com:master Oct 23, 2024
6 checks passed
Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 34
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-maryia-matskevich-deriv-webrel-3262-c-59d482.binary.sx/

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11475127783

Details

  • 1 of 5 (20.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 53.718%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/wallets/src/components/WalletsCarouselContent/WalletsCarouselContent.tsx 1 5 20.0%
Totals Coverage Status
Change from base Build 11474094392: 0.0%
Covered Lines: 35166
Relevant Lines: 60894

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants