Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aswathy/feat:Adding the new attributes user_id and anonymous_id #17895

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

aswathy-deriv
Copy link
Contributor

@aswathy-deriv aswathy-deriv commented Dec 24, 2024

Changes:

To improve the logical separation of user identity properties, allowing for better flexibility and accuracy when segmenting users based on either anonymous_id or user_id. This ensures consistency across the Analytics package and GrowthBook, eliminates redundancy, and enhances data quality for experiments and analysis.
Define the attribute names:
anonymous_id
user_id
Ensure alignment between GrowthBook and the Analytics package.
Verify consistency of the attribute names in the Analytical package and GrowthBook.

Screenshots:

Please provide some screenshots of the change.

Copy link

vercel bot commented Dec 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 25, 2024 11:59am

@coveralls
Copy link

coveralls commented Dec 24, 2024

Pull Request Test Coverage Report for Build 12492702225

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 19 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.002%) to 53.885%

Files with Coverage Reduction New Missed Lines %
packages/core/src/App/AppContent.tsx 19 0.0%
Totals Coverage Status
Change from base Build 12478543839: 0.002%
Covered Lines: 33040
Relevant Lines: 57140

💛 - Coveralls

Copy link
Contributor

github-actions bot commented Dec 24, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17895](https://github.com/deriv-com/deriv-app/pull/17895)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-aswathy-deriv-useriddistribution.binary.sx?qa_server=red.derivws.com&app_id=24254
    - **Original**: https://deriv-app-git-fork-aswathy-deriv-useriddistribution.binary.sx
- **App ID**: `24254`

Copy link
Contributor

github-actions bot commented Dec 24, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 33
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-aswathy-deriv-useriddistribution.binary.sx/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants