Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WALL] Lubega / WALL-5262 / Wallets P2P standalone redirection banner #17903

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

lubega-deriv
Copy link
Contributor

Changes:

  • Added redirect function to standalone P2P staging and production links using real fiat trading account's token
  • Created banner component for P2P redirection for all screen sizes
  • Updated accounts list and p2p banner component unit tests

Screenshots:

Bildschirmaufnahme.2024-12-26.um.5.11.11.PM.mov

Copy link

vercel bot commented Dec 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 6, 2025 7:43am

@lubega-deriv lubega-deriv changed the title feat: p2p standalone redirection banner [WALL] Lubega / WALL-5262 / Wallets P2P standalone redirection banner Dec 26, 2024
@coveralls
Copy link

coveralls commented Dec 26, 2024

Pull Request Test Coverage Report for Build 12628293182

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 8 of 19 (42.11%) changed or added relevant lines in 4 files are covered.
  • 1184 unchanged lines in 19 files lost coverage.
  • Overall coverage decreased (-0.1%) to 53.75%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/wallets/src/helpers/urls.ts 1 4 25.0%
packages/api-v2/src/hooks/useGrowthbookIsOn.ts 0 8 0.0%
Files with Coverage Reduction New Missed Lines %
packages/core/src/Utils/Analytics/index.ts 2 0.0%
packages/trader/src/AppV2/Components/ServiceErrorSheet/service-error-sheet.tsx 2 92.55%
packages/trader/src/AppV2/Containers/Trade/trade.tsx 3 88.46%
packages/trader/src/AppV2/Hooks/useContractsForCompany.ts 4 86.55%
packages/core/src/App/Components/Elements/WhatsApp/whatsapp.tsx 5 6.25%
packages/core/src/App/Containers/Layout/header/header.tsx 5 56.79%
packages/reports/src/Containers/open-positions.tsx 5 85.02%
packages/core/src/App/Containers/Layout/header/dtrader-header.tsx 6 67.61%
packages/components/src/components/page-overlay/page-overlay.tsx 9 0.0%
packages/trader/src/AppV2/Containers/Trade/trade-types.tsx 10 83.09%
Totals Coverage Status
Change from base Build 12501168312: -0.1%
Covered Lines: 33068
Relevant Lines: 57311

💛 - Coveralls

Copy link
Contributor

github-actions bot commented Dec 26, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17903](https://github.com/deriv-com/deriv-app/pull/17903)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-lubega-deriv-wall-5262-p2p-standalone-3afa81.binary.sx?qa_server=red.derivws.com&app_id=31524
    - **Original**: https://deriv-app-git-fork-lubega-deriv-wall-5262-p2p-standalone-3afa81.binary.sx
- **App ID**: `31524`

Copy link
Contributor

github-actions bot commented Dec 26, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 28
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-lubega-deriv-wall-5262-p2p-standalone-3afa81.binary.sx/

Copy link
Contributor

@adrienne-deriv adrienne-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

farrah-deriv
farrah-deriv previously approved these changes Dec 26, 2024
nijil-deriv
nijil-deriv previously approved these changes Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants