Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRWT-4001 / Kate / Update trade storer on ws reconnect #17910

Merged

Conversation

kate-deriv
Copy link
Contributor

@kate-deriv kate-deriv commented Dec 27, 2024

Changes:

Added network status (state) as a dependency in order to filling up store with the latest data after reconnecting to the WS

Screenshots:

Please provide some screenshots of the change.

Copy link

vercel bot commented Dec 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 3, 2025 6:35am

Copy link
Contributor

github-actions bot commented Dec 27, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17910](https://github.com/deriv-com/deriv-app/pull/17910)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-kate-deriv-kate-grwt-4001wsreconnecting.binary.sx?qa_server=red.derivws.com&app_id=23819
    - **Original**: https://deriv-app-git-fork-kate-deriv-kate-grwt-4001wsreconnecting.binary.sx
- **App ID**: `23819`

Copy link
Contributor

github-actions bot commented Dec 27, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 28
🟧 Accessibility 70
🟧 Best practices 83
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-kate-deriv-kate-grwt-4001wsreconnecting.binary.sx/

@coveralls
Copy link

coveralls commented Dec 27, 2024

Pull Request Test Coverage Report for Build 12593613819

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 53.762%

Files with Coverage Reduction New Missed Lines %
packages/trader/src/App/Components/Elements/market-countdown-timer.tsx 1 83.7%
Totals Coverage Status
Change from base Build 12582227830: -0.003%
Covered Lines: 33056
Relevant Lines: 57281

💛 - Coveralls

@kate-deriv kate-deriv changed the title GRWT-4001 / Kate / Update trade storer on ws reconnect [WIP] GRWT-4001 / Kate / Update trade storer on ws reconnect Dec 27, 2024
@kate-deriv kate-deriv marked this pull request as ready for review December 27, 2024 13:56
@nijil-deriv nijil-deriv merged commit c27ce9a into deriv-com:master Jan 6, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants