Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuzhy/_/intercom by default #17915

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Nuzhy-Deriv
Copy link
Contributor

@Nuzhy-Deriv Nuzhy-Deriv commented Dec 31, 2024

This PR is to make intercom available by default and remove intercom if it's not enabled in Growthbook for purpose of testing Outbound campaigns by CS team.

Copy link

vercel bot commented Dec 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 31, 2024 3:20am

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12554771870

Details

  • 5 of 9 (55.56%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 53.789%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/core/src/App/Components/Elements/LiveChat/live-chat.tsx 0 2 0.0%
packages/hooks/src/useIntercom.ts 5 7 71.43%
Files with Coverage Reduction New Missed Lines %
packages/trader/src/App/Components/Elements/market-countdown-timer.tsx 1 83.7%
Totals Coverage Status
Change from base Build 12546760852: 0.0%
Covered Lines: 33053
Relevant Lines: 57255

💛 - Coveralls

Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17915](https://github.com/deriv-com/deriv-app/pull/17915)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-nuzhy-deriv-nuzhy-intercom-by-default.binary.sx?qa_server=red.derivws.com&app_id=24072
    - **Original**: https://deriv-app-git-fork-nuzhy-deriv-nuzhy-intercom-by-default.binary.sx
- **App ID**: `24072`

Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🟧 Performance 54
🟧 Accessibility 70
🟧 Best practices 83
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-nuzhy-deriv-nuzhy-intercom-by-default.binary.sx/

@Nuzhy-Deriv Nuzhy-Deriv marked this pull request as ready for review December 31, 2024 05:26
@Nuzhy-Deriv Nuzhy-Deriv changed the title Nuzhy/_/intercom by default[WIP] Nuzhy/_/intercom by default Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants