-
Notifications
You must be signed in to change notification settings - Fork 19
Ahmed: Refactor/champion chart to Master [DO NOT MERGE] #318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ahmed-deriv
wants to merge
73
commits into
beta
Choose a base branch
from
refactor/champion-chart
base: beta
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt-champion Ahmed/feat: add document to implement smart charts champion and adaptor layer
…ahmed/feat-adaptor-bug-fixes
Ahmed/Feat: Upgrade React 17x to 18.2.0 and Resolve Bugs
Dependency ReviewThe following issues were found:
License Issuespackage-lock.json
package.json
packages/trader/package.json
OpenSSF ScorecardScorecard details
Scanned Manifest Filespackage-lock.json
package.json
packages/api-v2/package.json
packages/api/package.json
packages/components/package.json
packages/core/package.json
packages/reports/package.json
packages/shared/package.json
packages/stores/package.json
packages/trader/package.json
|
Deploying derivatives-trader with
|
| Latest commit: |
060bc5c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://17e8c664.derivatives-trader.pages.dev |
| Branch Preview URL: | https://refactor-champion-chart.derivatives-trader.pages.dev |
…rt-package fix: update smart chart package to get latest changes
…med/feat--add-markers-smart-chart
…arkers-smart-chart
…lt-position chore: update drawing tools floating menu position
…er-color-update fix: add function to update accumulator barrier data
…ter-update-smart-chart
…e-smart-chart Ahmed/fix sync master update smart chart
…de-review-fixes Ahmed/fix refactor and claude review fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request upgrades the project to React 18, updates related dependencies, and replaces the
@deriv-com/derivatives-chartspackage with@deriv-com/smartcharts-championacross all packages. It also updates Babel configurations to use the automatic JSX runtime and modernizes plugin usage. These changes aim to ensure compatibility with React 18, improve build performance, and maintain up-to-date charting functionality.React 18 upgrade and dependency updates:
reactandreact-domdependencies to version 18.2.0 in all relevantpackage.jsonfiles, ensuring the project uses React 18 throughout.Charting library migration:
Replaced all references to
@deriv-com/derivatives-chartswith@deriv-com/smartcharts-championin dependencies, build configs, and code imports, ensuring the new charting library is used project-wide.Babel configuration modernization:
Switched Babel preset configuration to use the automatic JSX runtime for React (
runtime: "automatic") in all Babel config files, improving build performance and compatibility with React 18.Updated Babel plugins to use modern
transform-*plugins instead of legacyproposal-*plugins for class properties, object rest/spread, export namespace, optional chaining, and nullish coalescing operator.Webpack and alias changes:
Code cleanup and minor fixes: