-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] add bench/bench.c #6
base: master
Are you sure you want to change the base?
Conversation
#set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Werror -Wall -Wextra -pedantic -std=c99") | ||
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -Wextra -pedantic -std=c99") | ||
|
||
set(CMAKE_BUILD_DIRECTORY ${PROJECT_SOURCE_DIR}/build) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
afaik, this is not how cmake works, the build directory can be any path.
For example, you may want to keep a build_release and a build_debug directories.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's ok. and the CMAKE_BUILD_DIRECTORY
setting not working :D
i don't know why.
@@ -13,10 +21,11 @@ if(USE_IPP) | |||
add_definitions(-DUSE_IPP=1) | |||
endif(USE_IPP) | |||
|
|||
include_directories ("${PROJECT_SOURCE_DIR}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not? ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, mistake.
Hey, This is interesting and seems to be well done, but frankly, i am not sure i will merge it in my repository, even when it is completed, because i want to keep the dependencies to ffmpeg as optionnal as possible, since it can be a PITA, with its continuously changing api, and all the different versions in use. Actually, i was planning to make ffmpeg dependency completely optionnal (similarly to IPP) I could probably use your load/save functions, to support more image formats when ffmpeg is enabled, however. |
that's ok, and i agree make ffmpeg is one option. |
make bench test code is clean then
test_yuv_rgb.c
.DONE
ffmpeg_rgb24_to_yuv420p
ffmpeg_yuv420p_to_rgb24
std_rgb24_to_yuv420p
UNDONE
ipp_yuv420p_to_rgb24
ipp_rgb24_to_yuv420p
std_yuv420p_to_rgb24
and as your wish, the code indentations all with tabulations (hehe).
the undone things, i will add later.